Skip to content

Fixes #44#46

Merged
Jayprakash-SE merged 2 commits intoIDinsight:mainfrom
lakshaydahiya67:fix/login_not_working_in_docker
May 13, 2025
Merged

Fixes #44#46
Jayprakash-SE merged 2 commits intoIDinsight:mainfrom
lakshaydahiya67:fix/login_not_working_in_docker

Conversation

@lakshaydahiya67
Copy link
Contributor

@lakshaydahiya67 lakshaydahiya67 commented May 5, 2025 •
edited
Loading

fixed login not working in docker

Reviewer:
Estimate:

Ticket

Fixes: JIRA_TICKET_LINK

Description

Goal

Changes

Future Tasks (optional)

How has this been tested?

To-do before merge (optional)

Checklist

Fill with x for completed.

  • My code follows the style guidelines of this project
  • I have reviewed my own code to ensure good quality
  • I have tested the functionality of my code to ensure it works as intended
  • I have resolved merge conflicts
  • I have updated the automated tests (if applicable)
  • I have updated the requirements (if applicable)
  • I have updated the README file (if applicable)
  • I have updated affected documentation (if applicable)
  • I have added a blogpost in Latest Updates
  • I have updated the CI/CD scripts in .github/workflows/
  • I have updated the Terraform code

@lakshaydahiya67
Fixes IDinsight#44
2bd26b7 
fixed login not working in docker
@lakshaydahiya67
Copy link
Contributor Author

lakshaydahiya67 commented May 5, 2025

fix: Database connection and user authentication issue

Fixed login and signup functionality in the Experiments Engine by resolving PostgreSQL library dependencies in the Docker container.

Issue

  • User authentication (login/signup) failed with error "relation 'users' does not exist"
  • Database migrations weren't being applied correctly
  • Email verification service attempted to use placeholder AWS credentials

Root Cause

  • Missing PostgreSQL client libraries in the Docker container
  • This prevented the database migrations from running correctly at startup
  • Without migrations, database tables weren't created

Solution

  • Added proper PostgreSQL libraries (libpq5 and libpq-dev) to the Docker image
  • Ensured database host configuration correctly pointed to 'relational_db' service name
  • Successfully verified user authentication now works properly

Tested functionality with multiple user accounts. Login and signup now work as expected, though email verification requires valid AWS credentials or a local mail testing solution.

Closes #44
Fixes #44

sidravi1
sidravi1 previously requested changes May 6, 2025
View reviewed changes
Copy link
Member

@sidravi1 sidravi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Looks good. Just left a few comments. Mind resolving those and then I am approve the PR to be merged.

@lakshaydahiya67 lakshaydahiya67 requested a review from sidravi1 May 12, 2025 04:01
@lakshaydahiya67
Copy link
Contributor Author

lakshaydahiya67 commented May 13, 2025

@sidravi1
please give a review

@Jayprakash-SE Jayprakash-SE dismissed sidravi1’s stale review May 13, 2025 09:15

Comments has been resolved.

@Jayprakash-SE Jayprakash-SE merged commit c928e08 into IDinsight:main May 13, 2025
poornimaramesh added a commit that referenced this pull request May 26, 2025
@poornimaramesh
Squashed commit of the following:
b708a82 
commit ccf227b
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Wed May 21 21:24:38 2025 +0530

    Fix the ts errors

commit 2cbf107
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Wed May 21 21:18:40 2025 +0530

    Fix the removal of user from workspace

commit ebb7cd3
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Wed May 21 15:51:18 2025 +0530

    Addressed comments

commit 58aebfb
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Wed May 14 16:24:00 2025 +0530

    Removed user filter

commit 02f0c73
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Wed May 14 16:01:41 2025 +0530

    Fixed import

commit 64ae3ad
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Wed May 14 15:47:24 2025 +0530

    Minor fix

commit f9a5471
Merge: 424cd4d c928e08
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Wed May 14 15:08:21 2025 +0530

    Merge remote-tracking branch 'origin' into workspaces

commit 424cd4d
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Wed May 14 14:47:46 2025 +0530

    Addressed comments

commit c928e08
Author: Lakshay <116358226+lakshaydahiya67@users.noreply.github.com>
Date:   Tue May 13 14:45:08 2025 +0530

    Fixes #44 (#46)

commit 6026bb5
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Wed May 7 08:52:22 2025 +0300

    Fix formating

commit 3f5c0ec
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Wed May 7 08:43:10 2025 +0300

    Fix Ruff errors

commit ba23c1c
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Wed May 7 00:30:29 2025 +0300

    Fix the mypy error

commit f629487
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Mon May 5 14:44:38 2025 +0300

    Fix circular import

commit 6488f97
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Mon May 5 13:38:33 2025 +0300

    Fix errors

commit 4544023
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Mon May 5 13:16:43 2025 +0300

    Changed workspace UI

commit a84527b
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Mon May 5 00:18:29 2025 +0300

    Fix npm build errors

commit daf1f9f
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Sun May 4 23:51:22 2025 +0300

    Fix the tests

commit fcbc483
Merge: b508c4b 443e05b
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Sun May 4 11:39:29 2025 +0300

    Merge remote-tracking branch 'origin' into workspaces

commit b508c4b
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Sun May 4 11:38:51 2025 +0300

    Add API key history

commit 609f9d8
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Thu May 1 14:12:49 2025 +0300

    Removed the create workspace from switcher

commit b7ff0b5
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Thu May 1 13:58:07 2025 +0300

    Fix email link

commit 700fb36
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Thu May 1 13:12:43 2025 +0300

    Remove old sidebar

commit 64768d6
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Thu May 1 13:08:56 2025 +0300

    New frontend

commit 43a2c38
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Thu May 1 02:04:05 2025 +0530

    Added workspace removal and user list

commit 88cc7aa
Merge: 219aea7 95e15a2
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Wed Apr 30 20:37:01 2025 +0530

    Merge branch 'main' into workspaces

commit 219aea7
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Tue Apr 22 03:40:04 2025 +0530

    File formating

commit c79830b
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Tue Apr 22 03:04:43 2025 +0530

    Adding the workspace feature

commit a2923ef
Merge: b183861 00daa42
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Wed Apr 16 02:25:09 2025 +0530

    Merge remote-tracking branch 'origin' into workspaces

commit b183861
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Fri Apr 4 04:14:05 2025 +0530

    Fix redirect issue

commit 3e86241
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Thu Apr 3 04:01:47 2025 +0530

    Added env variables for test

commit 3f0b611
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Thu Apr 3 03:49:02 2025 +0530

    Add user verification and password reset
poornimaramesh added a commit that referenced this pull request May 26, 2025
@poornimaramesh
Squashed commit of the following:
c0aa9c4 
commit b02ed75
Author: Aadhil Ahamed <aadhil2k4@gmail.com>
Date:   Sat May 24 21:53:07 2025 +0530

    Fix local development installation (#50)

commit c928e08
Author: Lakshay <116358226+lakshaydahiya67@users.noreply.github.com>
Date:   Tue May 13 14:45:08 2025 +0530

    Fixes #44 (#46)
poornimaramesh added a commit that referenced this pull request Jun 19, 2025
@poornimaramesh @Jayprakash-SE
Refactor frontend (#88)
83b0d98 
* Add user verification and password reset

* Added env variables for test

* Fix redirect issue

* Adding the workspace feature

* File formating

* Added workspace removal and user list

* New frontend

* Remove old sidebar

* Fix email link

* Removed the create workspace from switcher

* Add API key history

* Fix the tests

* Fix npm build errors

* Changed workspace UI

* Fix errors

* Fix circular import

* Fix the mypy error

* Fix Ruff errors

* Fix formating

* Squashed commit of the following:

commit 6026bb5
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Wed May 7 08:52:22 2025 +0300

    Fix formating

commit 3f5c0ec
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Wed May 7 08:43:10 2025 +0300

    Fix Ruff errors

commit ba23c1c
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Wed May 7 00:30:29 2025 +0300

    Fix the mypy error

commit f629487
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Mon May 5 14:44:38 2025 +0300

    Fix circular import

commit 6488f97
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Mon May 5 13:38:33 2025 +0300

    Fix errors

commit 4544023
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Mon May 5 13:16:43 2025 +0300

    Changed workspace UI

commit a84527b
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Mon May 5 00:18:29 2025 +0300

    Fix npm build errors

commit daf1f9f
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Sun May 4 23:51:22 2025 +0300

    Fix the tests

commit fcbc483
Merge: b508c4b 443e05b
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Sun May 4 11:39:29 2025 +0300

    Merge remote-tracking branch 'origin' into workspaces

commit b508c4b
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Sun May 4 11:38:51 2025 +0300

    Add API key history

commit 609f9d8
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Thu May 1 14:12:49 2025 +0300

    Removed the create workspace from switcher

commit b7ff0b5
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Thu May 1 13:58:07 2025 +0300

    Fix email link

commit 700fb36
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Thu May 1 13:12:43 2025 +0300

    Remove old sidebar

commit 64768d6
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Thu May 1 13:08:56 2025 +0300

    New frontend

commit 43a2c38
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Thu May 1 02:04:05 2025 +0530

    Added workspace removal and user list

commit 88cc7aa
Merge: 219aea7 95e15a2
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Wed Apr 30 20:37:01 2025 +0530

    Merge branch 'main' into workspaces

commit 219aea7
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Tue Apr 22 03:40:04 2025 +0530

    File formating

commit c79830b
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Tue Apr 22 03:04:43 2025 +0530

    Adding the workspace feature

commit a2923ef
Merge: b183861 00daa42
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Wed Apr 16 02:25:09 2025 +0530

    Merge remote-tracking branch 'origin' into workspaces

commit b183861
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Fri Apr 4 04:14:05 2025 +0530

    Fix redirect issue

commit 3e86241
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Thu Apr 3 04:01:47 2025 +0530

    Added env variables for test

commit 3f0b611
Author: Jay Prakash <0freerunning@gmail.com>
Date:   Thu Apr 3 03:49:02 2025 +0530

    Add user verification and password reset

* Addressed comments

* Minor fix

* Fixed import

* Removed user filter

* Addressed comments

* Fix the removal of user from workspace

* Fix the ts errors

* WIP: models and schemas

* WIP: models and schemas

* Squashed commit of the following:

commit b02ed75
Author: Aadhil Ahamed <aadhil2k4@gmail.com>
Date:   Sat May 24 21:53:07 2025 +0530

    Fix local development installation (#50)

commit c928e08
Author: Lakshay <116358226+lakshaydahiya67@users.noreply.github.com>
Date:   Tue May 13 14:45:08 2025 +0530

    Fixes #44 (#46)

* fix tests

* working version of models, schemas and routers for creating experiments

* working version of get all mabs endpoint

* add epxeriment type get router

* add get routers for exp by id

* debugging endpoints

* add bulk delete router

* debugging, WIP sampling utils

* fix linting

* WIP: draw arm + update arm routers

* fresh start migrations

* add choose arm and update arm routers + functions

* fix linting

* debug routers for beta-binary mab

* debug normal/real-valued experiments

* debug Bayes AB beta-binom

* debug mabs

* debug cmabs

* update autofail

* delete old routers and migrations

* debugging

* fix messages test

* fix notifications and tests

* debug autofail and fix corresponding tests

* experiment tests for mabs

* update tests for Bayes AB experiments

* add tests for CMAB

* delete old tests

* merge changes from refactor

* merge changes from tests

* update display experiments page

* fix experiment viz

* debug prior-reward config

* add context page

* add input arms page

* add notifications

* debugging

* clean up

* merge changes from base refactor

* fix tests

---------

Co-authored-by: Jay Prakash <0freerunning@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suzinyou suzinyou Awaiting requested review from suzinyou suzinyou is a code owner

@lickem22 lickem22 Awaiting requested review from lickem22 lickem22 is a code owner

@amiraliemami amiraliemami Awaiting requested review from amiraliemami amiraliemami is a code owner

@poornimaramesh poornimaramesh Awaiting requested review from poornimaramesh poornimaramesh is a code owner

@ziakhan04 ziakhan04 Awaiting requested review from ziakhan04

@markbotterill markbotterill Awaiting requested review from markbotterill markbotterill is a code owner

@tonyzhao6 tonyzhao6 Awaiting requested review from tonyzhao6 tonyzhao6 is a code owner

@sidravi1 sidravi1 Awaiting requested review from sidravi1 sidravi1 is a code owner

1 more reviewer

@Jayprakash-SE Jayprakash-SE Jayprakash-SE approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lakshaydahiya67 @sidravi1 @Jayprakash-SE

Comments