Enhanced WIFA Support #162
Conversation
Fixing missing xarray import in __init__.py
|
@kilojoules there are conflicts that must be resolved. @bayc please review this PR once conflicts are resolved |
move scada schema to schemas folder
rename outputs to simulation_outputs
| title: Effective Wind Speed in m/s | ||
| description: Effective wind speed | ||
| $ref: "common.yaml#/definitions/multi_dimensional_data" | ||
| wind_direction: |
There was a problem hiding this comment.
Consider how this interacts with energy_resource.yaml as an input.
| title: Time | ||
| description: Timestamps for the data points | ||
| $ref: "common.yaml#/definitions/multi_dimensional_coordinate" | ||
| turbine: |
There was a problem hiding this comment.
Couple with turbine_identifiers in the wind farm schema?
| $ref: "./common.yaml#/definitions/multi_dimensional_coordinate" | ||
| oneOf: | ||
| - $ref: "./common.yaml#/definitions/multi_dimensional_data" | ||
| - $ref: "./common.yaml#/definitions/multi_dimensional_coordinate" |
There was a problem hiding this comment.
Consider the difference between multi_dimensional_data and multi_dimensional_coordinate.
| $ref: "./common.yaml#/definitions/multi_dimensional_data" | ||
|
|
||
| #~ | ||
| turbine_data: |
There was a problem hiding this comment.
How to differentiate for the user the difference between this turbine_data and the turbine_data in scada_data.
| wind_farm: | ||
| $ref: "./wind_farm.yaml" | ||
| #~ | ||
| simulation_output: |
There was a problem hiding this comment.
Figure out how to prevent a recursive loop with the hook here and in wind_energy_system. Same for scada_data.
bayc
left a comment
bayc
left a comment
There was a problem hiding this comment.
Approved for working needs, with some comments to be addressed in the future.
5 participants
Proposed changes to support WIFA tool https://github.com/EUFLOW/WIFA
Major Additions
outputs.yamltosimulation_outputs.yamlschema, which is now definition dedicated to handling simulation output data associated with wind energy systemsscada_data.yamlschema for records of real wind farm operationSchema Enhancements
Technical Improvements