Improving consistency wind fam layout definition#174
Merged
ptrbortolotti merged 1 commit intoIEAWindSystems:mainfrom Feb 13, 2026
Merged
Improving consistency wind fam layout definition#174ptrbortolotti merged 1 commit intoIEAWindSystems:mainfrom
ptrbortolotti merged 1 commit intoIEAWindSystems:mainfrom
Conversation
…ine_identifiers to layouts
Collaborator
|
@kilojoules @bayc please provide your review |
bayc
approved these changes
Feb 5, 2026
Collaborator
bayc
left a comment
bayc
left a comment
There was a problem hiding this comment.
This PR makes sense to me, thanks for the addition @lejeunemax !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improving consistency wind fam layout definition
This PR addresses two main issues related to schema consistency:
common.Coodinatesshould mirror the structure ofcommon.Coordinate.This requires adding azandcrsproperties to theCoordinatesstructure.turbine_identifiersis likely to change with the layout and should terefore be moved underlayouts.