Adding new ERU types

[anamariaescobar]

Is your feature request related to a problem? Please describe.
New type of ERUs have been developed, so we need to add them to the dropdown menu. Also notice that Basecamp needs to be removed as further classification per sizes has been added.
https://prddsgocdnapi.azureedge.net/en/deployments/eruowner/39/change/

Describe the solution you'd like
Add new types of ERUs:

• Water Supply and rehabilitation
• Household Water Treatment and safe storage
• Cholera Case management at Community level
• Safe and Dignified Burials
• Community Based Surveillance
• Base Camp – S
• Base Camp – M
• Base Camp – L

Where does the data come from and how is it maintained?
Manually by the Surge team

Should there be any restrictions around viewing or updating information related to this feature
Maintain the current behavior.

@szabozoltan69

[szabozoltan69]

Which value can be converted the recent Basecamp values?

[anamariaescobar]

oh! Good question! then lest just leave Basecamp then and adding the other 3 Basecamps, eventually the data from Basecamp will be updated to S, M or L.

[szabozoltan69]

Change is done, deployed to staging.
https://github.com/IFRCGo/go-api/blob/develop/deployments/models.py#L18-L53

[anamariaescobar]

HI @szabozoltan69, I just checked in staging and the dropdown in the backend looks good, but when I created a new ERU in the front end appears like "Undefined"

[szabozoltan69]

It's true that I made only backend change. Some frontend change also needed. @vdeak – could you please give a check to this?

=== utils/eru-types.js ===
const eruTypes = {
  '0': 'Basecamp',
  '1': 'IT & Telecom',
  '2': 'Logistics',
  '3': 'RCRC Emergency Hospital',
  '4': 'RCRC Emergency Clinic',
  '5': 'Relief',
  '6': 'WASH M15',
  '7': 'WASH MSM20',
  '8': 'WASH M40'
};

Is it possible that instead of this wired-in list these pairs could come from backend?
(Or we should put a comment to both places so that next occasion we should not forget the double work on both sides.)

The augmentation would be:

        ,
        '9': 'Water Supply and rehabilitation',
        '10': 'Household Water Treatment and safe storage',
        '11': 'Cholera Case management at Community level',
        '12': 'Safe and Dignified Burials',
        '13': 'Community Based Surveillance',
        '14': 'Base Camp – S',
        '15': 'Base Camp – M',
        '16': 'Base Camp – L'

[szabozoltan69]

@batpad - if you have any suggestion concerning this, tell us! :-)

So the basic question is: which is better, to maintain 2 lists (backend/frontend) or to collect these data from backend always?

[batpad]

Whoops, I'm sorry I missed seeing the notification here.

@szabozoltan69 as discussed in chat:

• For now, let's just add these new types to the frontend list.
• Let's create a ticket to remove the list on the frontend and just have it pull from the API, so we don't maintain two lists in the future.

[batpad]

The augmentation would be:

That looks really good to me @szabozoltan69, thank you. Would you be able to go ahead with the change and make a PR on the frontend?

[szabozoltan69]

IFRCGo/go-frontend#1915