Skip to content

Update base docker image#807

Merged
GergiH merged 2 commits intodevelopfrom
update-base-image
Jul 8, 2020
Merged

Update base docker image#807
GergiH merged 2 commits intodevelopfrom
update-base-image

Conversation

@geohacker
Copy link
Copy Markdown
Collaborator

This PR updates the base docker image from debian jessie to debian buster. It's essential to do this for fetching new packages for GDAL for using with geo django models.

Changes

  • Dockerfile uses a new image
  • Updates some dependencies like Markupsafe and setuptools
  • Remove pygraphviz as per conversation with @batpad

Checklist

Things that should succeed before merging.

  • Updated/ran unit tests
  • Updated CHANGELOG.md

Release

If there is a version update, make sure to tag the repository with the latest version.

@geohacker geohacker requested review from GergiH, batpad and thenav56 July 7, 2020 11:24
@batpad
Copy link
Copy Markdown
Collaborator

batpad commented Jul 7, 2020

This looks fine to me @geohacker - pygraphviz was only used to be able to generate this graph of all the models as a management command. We can live without it, and I'm the only person who used that as far as I know. It will definitely be good to have some testing, but I think it's a good time to merge in changes like this, and I overall like the idea of updating our docker base image to a newer Debian.

@thenav56 @GregoryHorvath could you please take a look and approve if this seems all fine to you?

Comment thread Dockerfile
Copy link
Copy Markdown
Collaborator

@GergiH GergiH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole thing ran smoothly for me, I only got 2 errors but these are there for ages now so I guess there's in action to do there:

debconf: delaying package configuration, since apt-utils is not installed
ERROR: elasticsearch 6.0.0 has requirement urllib3<1.23,>=1.21.1, but you'll have urllib3 1.24.2 which is incompatible.

cc @batpad

@GergiH
Copy link
Copy Markdown
Collaborator

GergiH commented Jul 8, 2020

@geohacker should I deploy this to staging then asap?

@geohacker
Copy link
Copy Markdown
Collaborator Author

@GregoryHorvath I'll just fix the minor thing @thenav56 pointed out and then we can deploy to staging!

@GergiH GergiH merged commit f27798d into develop Jul 8, 2020
@GergiH
Copy link
Copy Markdown
Collaborator

GergiH commented Jul 8, 2020

@geohacker deployed

@geohacker geohacker deleted the update-base-image branch July 8, 2020 10:44
@batpad batpad mentioned this pull request Jul 28, 2020
5 tasks
@nanometrenat
Copy link
Copy Markdown
Contributor

Released this morning I am told

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants