Skip to content
This repository was archived by the owner on Sep 4, 2024. It is now read-only.

Update Surge page map with ERUs and Personnel data#2012

Merged
batpad merged 3 commits intodevelopfrom
feature/update-surge-map
Aug 31, 2021
Merged

Update Surge page map with ERUs and Personnel data#2012
batpad merged 3 commits intodevelopfrom
feature/update-surge-map

Conversation

@willemarcel
Copy link
Copy Markdown
Collaborator

Contributes to #1965

@willemarcel willemarcel requested a review from batpad August 26, 2021 00:19
@batpad
Copy link
Copy Markdown
Contributor

batpad commented Aug 26, 2021

@willemarcel wow! This seems to work really well for me.

Just couple of minor things:

  • Can we make the styling of the dots match the styling used on the home-page map? You will notice the fully opaque centre of the circle is all the same size and then the "scaled" part has some transparency, so it doesn't look like a big opaque dot.

  • In the popup, can we make the title of the emergency link to the actual emergency?

Apart from these, it looks really good to me. Will spend some more time testing and going through the code.

When we are testing a branch, we use surge.sh to deploy a testing version of the site (without having to merge to develop). You can do this with:

  • yarn build-staging
  • yarn deploy-surge

(Instructions are also in the README) - Will be great if you can deploy to a Surge URL and we can ask @anamariaescobar and others to test. (It is better if you do it since then you will also be able to deploy updates).

@willemarcel willemarcel force-pushed the feature/update-surge-map branch from 86607aa to 6718c6d Compare August 26, 2021 12:24
@willemarcel
Copy link
Copy Markdown
Collaborator Author

@batpad I've made the modifications you suggested.

@anamariaescobar you can preview the changes in the Surge/Deployments map in https://upbeat-bartik-c5abb7.netlify.app

@batpad
Copy link
Copy Markdown
Contributor

batpad commented Aug 26, 2021

This is looking great to me, @willemarcel - will just wait for any comments from @anamariaescobar .

@anamariaescobar
Copy link
Copy Markdown

HI @batpad @willemarcel, indeed this also looks great from my side!! Thank you!!

@tovari
Copy link
Copy Markdown

tovari commented Aug 26, 2021

Hi @willemarcel, @batpad. Looks good, but I think, the colors need to be aligned with those on the active operations map:
#ff9e00
#4c5d9b
Thanks!

@willemarcel
Copy link
Copy Markdown
Collaborator Author

Hi @willemarcel, @batpad. Looks good, but I think, the colors need to be aligned with those on the active operations map:
#ff9e00
#4c5d9b
Thanks!

@tovari I pushed an update with the new map colours and deployed it: https://upbeat-bartik-c5abb7.netlify.app/deployments

@tovari
Copy link
Copy Markdown

tovari commented Aug 30, 2021

Hi @willemarcel, I think the displayed ERUs on the map are filtered by the ERU list pages, i.e. only those are visible that are on the actual page of the list. I could not check this for deployments as there is only 1 page at the moment.
Check USA on the screenshots.
Further issue is that there is no mixed item is displayed on the map (USA should be).
Also, when clicking on page 3, the page breaks.
surge-map-1b

surge-map-2

@willemarcel
Copy link
Copy Markdown
Collaborator Author

Thanks for reporting the bugs, @tovari. I have already fixed them. You can check on the same URL.

@batpad
Copy link
Copy Markdown
Contributor

batpad commented Aug 31, 2021

Thanks @willemarcel - am going to go ahead and merge this to develop - we can make any additional fixes as separate branches.

@batpad batpad merged commit e98a551 into develop Aug 31, 2021
@batpad batpad deleted the feature/update-surge-map branch August 31, 2021 04:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants