Skip to content
This repository was archived by the owner on Sep 4, 2024. It is now read-only.

Add "Deployments over the last year" chart to the Surge page#2018

Merged
batpad merged 1 commit intodevelopfrom
feature/last-year-deployments-chart
Aug 31, 2021
Merged

Add "Deployments over the last year" chart to the Surge page#2018
batpad merged 1 commit intodevelopfrom
feature/last-year-deployments-chart

Conversation

@willemarcel
Copy link
Copy Markdown
Collaborator

@willemarcel willemarcel commented Aug 30, 2021

  • Create separate component TimeLineChart and use it both on deployments and in emergencies page

PR deployed at https://ifrc-go-new-deploy-chart.surge.sh

@willemarcel willemarcel requested a review from batpad August 30, 2021 20:36
@frozenhelium
Copy link
Copy Markdown
Member

@willemarcel We already have useRequest hook for fetching data.
Example:

const {
pending: fetchingCountries,
response: countriesResponse,
} = useRequest<ListResponse<Country>>({
url: 'api/v2/country/',
query: limitQuery,
});

CC: @batpad

@batpad
Copy link
Copy Markdown
Contributor

batpad commented Aug 31, 2021

Thanks so much for the catch and review @frozenhelium -

@willemarcel does this make sense and would you be able to make this change?

@willemarcel willemarcel force-pushed the feature/last-year-deployments-chart branch from 3257b4d to 94b0d3b Compare August 31, 2021 11:06
@willemarcel
Copy link
Copy Markdown
Collaborator Author

@batpad @frozenhelium I've made the change in order to use useRequest.

@batpad
Copy link
Copy Markdown
Contributor

batpad commented Aug 31, 2021

This looks good to me and works well.

@frozenhelium could you take a final look? Thanks.

@batpad batpad merged commit 380e36d into develop Aug 31, 2021
@batpad batpad deleted the feature/last-year-deployments-chart branch August 31, 2021 11:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants