Conversation
lzanita09
commented
Jan 16, 2020
lzanita09
commented
- Copy changes
- Button size tweaks
- Simplify TextView padding adjustment logic
- Always draw ConnectButton border
* Copy changes * Button size tweaks * Simplify TextView padding adjustment logic * Always draw ConnectButton border
| this.onDarkBackground = onDarkBackground; | ||
| this.startIconBackgroundColor = | ||
| onDarkBackground ? ContextCompat.getColor(context, R.color.ifttt_start_icon_background_on_dark) | ||
| : Color.BLACK; |
There was a problem hiding this comment.
is this intentional? This color is used below, if we don't set it in the constructor, how can we use it where required?
There was a problem hiding this comment.
We no longer use this field because we are going to use the backgroundColor, which will be set later on in the process, to derive the background color for the start icon.
|
I am assuming all the dimens are same as those for the connect button in the app (https://github.com/IFTTT/IFTTTAndroid/pull/3924) |
|
Yep. |
| <?xml version="1.0" encoding="utf-8"?> | ||
| <resources> | ||
| <dimen name="ifttt_text_padding_horizontal">72dp</dimen> | ||
| <dimen name="ifttt_text_padding_horizontal">@dimen/ifttt_connect_button_height</dimen> |
There was a problem hiding this comment.
I would say we could leave this as 72dp instead of setting it as the connect button height. Those two dimens are unrelated and if we decide to change height, this will change too
There was a problem hiding this comment.
They are related actually, the padding should match exactly how tall the connect button is.
2 participants
