Swift 6 migration with comprehensive unit tests#6
Merged
Conversation
Migrated codebase from Swift 5.10 to Swift 6.0 with strict concurrency enabled. Added @preconcurrency imports for legacy dependencies and fixed concurrency issues across managers, listeners, and notifiers. Added 66 new unit tests covering TriggerType, ThiefDto, DatabaseDtoList, AppSettings models, and TriggerManager with complete test coverage for models and settings. All 111 tests pass with Swift 6.0 strict concurrency. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
ikorich
added a commit
that referenced
this pull request
Jan 1, 2026
* chore: complete Swift 6 migration and add comprehensive unit tests (#6) Migrated codebase from Swift 5.10 to Swift 6.0 with strict concurrency enabled. Added @preconcurrency imports for legacy dependencies and fixed concurrency issues across managers, listeners, and notifiers. Added 66 new unit tests covering TriggerType, ThiefDto, DatabaseDtoList, AppSettings models, and TriggerManager with complete test coverage for models and settings. All 111 tests pass with Swift 6.0 strict concurrency. * refactor: implement Swift 6 actors for XPC service isolation (#7) This commit completes Phase 3 of the Swift 6 modernization by adding proper actor isolation to all event listeners and XPC service communication. Restores @mainactor to BaseListenerProtocol and wraps all XPC callbacks in MainActor hops to eliminate data races. All listeners now properly synchronize state mutations on the main thread, fixing issues with event listeners being called only once. All 110 tests pass. This prevents git from tracking temporary Crystal session directories. * set min os version to 14.1 * docs: update CLAUDE.md and README.md to latest format standards (#8) - Refactored CLAUDE.md with cleaner Overview section (Type, Stack, Architecture, Company) - Added MUST/SHOULD/MUST NOT development rules format for clarity - Added Core Commands section with bash examples for building and testing - Added Quick Find Commands for efficient code navigation - Consolidated MAS vs Non-MAS configuration into clear comparison table - Simplified agents/skills into single consolidated tables - Updated README.md with streamlined structure and removed verbose sections - Removed Troubleshooting, Info.plist Requirements, and Resources sections - Removed references to ARCHITECTURE.md throughout documentation - Deleted ARCHITECTURE.md as consolidation is complete * feat: add design system and accessibility improvements (#9) - Create DesignSystem.swift with centralized design tokens (spacing, colors, typography, shadows) - Add comprehensive accessibility modifiers across all UI views (VoiceOver support) - Extract debug print pattern into View+DebugPrintChanges extension - Refactor LastThiefDetectionView into smaller, type-checkable components - Update copyright year to 2026 across all source files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
🤖 Generated with Claude Code