Skip to content

Adding manifest for commenting annotation camera view activation via …#80

Open
gjcope wants to merge 1 commit into
IIIF:mainfrom
gjcope:dev-activating-scope
Open

Adding manifest for commenting annotation camera view activation via …#80
gjcope wants to merge 1 commit into
IIIF:mainfrom
gjcope:dev-activating-scope

Conversation

@gjcope
Copy link
Copy Markdown
Contributor

@gjcope gjcope commented May 29, 2026

…scope

@gjcope gjcope requested a review from JulieWinchester May 29, 2026 19:28
@gjcope
Copy link
Copy Markdown
Contributor Author

gjcope commented May 29, 2026

@glenrobson is this validation fail a validator issue? It's flagging a duplicate id, but I think in this case it is necessary unless I'm misunderstanding the spec (totally possible!)

@JulieWinchester
Copy link
Copy Markdown
Contributor

For what it's worth, I've also seen validator errors on trying to implement the scope shorthand elsewhere.

@vincentmarchetti
Copy link
Copy Markdown
Contributor

I think the manifest is valid; the requirement that ids be strictly unique is too stringent, because it doesn't allow for referencing an annotation from another annotation, as would be required for scope and lookAt properties.

A useful validator related to unique id', in that it would catch true errors, would be to check that is two JSON objects have the same id, they must also have the same type.

@vincentmarchetti
Copy link
Copy Markdown
Contributor

The presentation-validator code already has the ability to ignore some properties when checking for unique ids. This list already includes "lookAt", "source", and others. I have submitted a PR IIIF/presentation-validator#216 to add "scope" to this list.

All the manifests in the gjcope/dev-activating-scope branch pass this version of the validator code.

@gjcope
Copy link
Copy Markdown
Contributor Author

gjcope commented Jun 5, 2026

Thanks @vincentmarchetti !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants