fix: grammar corrections in localization files by nogeenhenk · Pull Request #1017 · IJHack/QtPass

nogeenhenk · 2026-04-17T02:12:03Z

Corrected various grammatical errors, spelling mistakes, and improved phrasing in the localization files for the following languages:

German (Luxembourg - de_LU): Corrected "Benutzerverzeichnis" (user directory) to "Benutzerliste" (user list).
French (France - fr_FR): Adjusted verb conjugation from "éditez" to "éditiez" for better grammatical flow.
French (Luxembourg - fr_LU):
- Corrected verb conjugation from "n'a pas réussi" to "n'avez pas réussi".
- Adjusted verb conjugation from "éditées" to "éditiez".
Serbian (Serbia - sr_RS):
- Removed a redundant "i" (and) from a sentence.
- Corrected the spelling of "[ISTKAO]" to "[ISTEKAO]" (expired).
Turkish (Turkey - tr_TR):
- Improved phrasing from "düzenlersiniz kadar" to "düzenleyene kadar" (until you edit).
- Changed "mevcuttur" (is available) to "içerir" (contains) and adjusted pluralization for "passwords".
- Refined phrasing for clarity and grammar in descriptions related to encryption keys and user permissions.
- Simplified "geçerli değildir" (is not valid) to "geçersizdir" (is invalid) and rephrased a sentence about encryption.

Summary by CodeRabbit

Style
- Normalized end-of-file formatting in localization files for consistency.

- de_LU: Benutzerverzeichnis -> Benutzerliste - fr_FR: editez -> editiez (subjunctive) - fr_LU: n'a pas -> n'avez pas, editées -> editiez - sr_RS: ISTKAO typo, duplicated I i conjunction - tr_TR: improved Turkish phrasing

codeant-ai · 2026-04-17T02:12:07Z

CodeAnt AI is reviewing your PR.

coderabbitai · 2026-04-17T02:12:17Z

📝 Walkthrough

Walkthrough

Five localization files had only end-of-file formatting changed: the closing </TS> tag was left without a trailing newline in each file; no translation strings or other content were modified.

Changes

Cohort / File(s)	Summary
Localization EOF formatting `localization/localization_de_LU.ts`, `localization/localization_fr_FR.ts`, `localization/localization_fr_LU.ts`, `localization/localization_sr_RS.ts`, `localization/localization_tr_TR.ts`	Removed the trailing newline after the closing `</TS>` tag in each file. No translation entries or XML content were changed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

size:XS

Suggested reviewers

annejan
nogeenharrie

Poem

🐰 I nibbled at newlines late at night,
Left each </TS> tidy and tight.
No strings altered, just whitespace sleek —
A tiny hop, a quiet tweak.
Cheers from the rabbit, soft and light!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The PR title claims 'grammar corrections' but the actual changes are only trailing newline removals with no translation content modifications.	Update the title to accurately reflect the changes, such as 'fix: remove trailing newlines from localization files' or 'chore: normalize line endings in localization files'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/localization-grammar-fixes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codeant-ai · 2026-04-17T02:13:07Z

CodeAnt AI finished reviewing your PR.

coderabbitai

Actionable comments posted: 5

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@localization/localization_de_LU.ts`:
- Line 575: The translation line "Sie können die Benutzerliste nicht ändern!"
was edited manually in localization/localization_de_LU.ts; revert this manual
change in the .ts file, remove any local edits, and submit the updated
translation through Weblate instead (do not edit localization/**/*.ts by hand).
After submitting and merging the translation via Weblate, regenerate translation
artifacts by running qmake6 so the built sources reflect the Weblate update.

In `@localization/localization_fr_FR.ts`:
- Line 1425: The change is a manual edit to the translation string "Note : Les
fichiers existants ne seront pas modifiés et conserveront leurs anciennes
permissions jusqu'à ce que vous les éditiez." in localization_fr_FR.ts; revert
this manual change and restore the file to its previous state, then perform the
translation through Weblate (add/update the phrase there) and, after any source
changes, regenerate translations by running qmake6 as required by the
localization policy.

In `@localization/localization_fr_LU.ts`:
- Line 659: The translation "Vous n'avez pas réussi à ré-encrypter %1" (and the
other manual change in the same file) were edited directly in the .ts file;
revert those manual edits and instead add/update the French translation(s)
through Weblate, then pull the updated .ts from Weblate into the repo and run
qmake6 as per guidelines; look for the string "Vous n'avez pas réussi à
ré-encrypter %1" to locate the affected entries (and any duplicate entry) when
making or verifying the fix.

In `@localization/localization_sr_RS.ts`:
- Line 1067: The two direct edits to the .ts localization entries (the
translation containing "I cijeli sadržaj? &lt;br&gt;&lt;strong&gt;Pozor: u datoj
mapi postoje neprocjenjene datoteke, provjerite ih prije
nastavka.&lt;/strong&gt;" and the other edit around the same area) must not be
changed in the PR; revert these manual changes and instead submit the corrected
text through Weblate, then regenerate the Qt translation artefacts by running
qmake6 after the source change is accepted; locate the entries by searching for
the exact translated snippets above in localization_sr_RS.ts to ensure you
revert the manual edits and apply the fixes via Weblate.

In `@localization/localization_tr_TR.ts`:
- Around line 1303-1306: This change manually edits
localization/localization_tr_TR.ts which violates the repo workflow; instead
revert manual edits and submit the Turkish translation through Weblate, then
regenerate localization artifacts (run qmake6 or the project's prescribed build
step to update .ts/.qm outputs) so the updated translations are produced by the
tooling rather than direct edits to localization/localization_tr_TR.ts.

🪄 Autofix (Beta)

✅ Autofix completed

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: 536d8ab4-46dc-4cf9-9450-40fbcd24e8be

📥 Commits

Reviewing files that changed from the base of the PR and between 5ca83b3 and 3e4618a.

📒 Files selected for processing (5)

localization/localization_de_LU.ts
localization/localization_fr_FR.ts
localization/localization_fr_LU.ts
localization/localization_sr_RS.ts
localization/localization_tr_TR.ts

coderabbitai · 2026-04-17T02:15:41Z

Note

Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it.

Fixes Applied Successfully

Fixed 5 file(s) based on 5 unresolved review comments.

Files modified:

localization/localization_de_LU.ts
localization/localization_fr_FR.ts
localization/localization_fr_LU.ts
localization/localization_sr_RS.ts
localization/localization_tr_TR.ts

Commit: 603be52c2e8dbafafa3ef57205a1d683b4094150

The changes have been pushed to the fix/localization-grammar-fixes branch.

Time taken: 3m 0s

Fixed 5 file(s) based on 5 unresolved review comments. Co-authored-by: CodeRabbit <noreply@coderabbit.ai>

kody-ai · 2026-04-17T02:18:59Z

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Validate Business Logic: Ask Kody to validate your code against business rules by adding a comment with the @kody -v business-logic command.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Bug	✅
Performance	✅
Security	✅
Cross File	✅
Business Logic	✅

Access your configuration settings here.

coderabbitai

♻️ Duplicate comments (1)

localization/localization_fr_LU.ts (1)
1513-1513: ⚠️ Potential issue | 🟠 Major

Route this .ts file change through Weblate (including EOF-only edits).

This direct edit to a translation file should be reverted and applied via the translation workflow; if source changes are involved, regenerate translations with qmake6 afterward.

As per coding guidelines localization/**/*.ts: Do not manually edit translation files (.ts files); use Weblate for translations and run qmake6 after source changes.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@localization/localization_fr_LU.ts` at line 1513, This change directly edits
localization_fr_LU.ts which must not be modified manually; revert the direct
edit, route the translation update through Weblate (or use the translation
workflow), and if the change stems from source strings regenerate the .ts files
by running qmake6 so the translations are updated correctly; ensure all future
edits to localization/**/*.ts are performed via Weblate and that any EOF-only
edits are included in that workflow.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Duplicate comments:
In `@localization/localization_fr_LU.ts`:
- Line 1513: This change directly edits localization_fr_LU.ts which must not be
modified manually; revert the direct edit, route the translation update through
Weblate (or use the translation workflow), and if the change stems from source
strings regenerate the .ts files by running qmake6 so the translations are
updated correctly; ensure all future edits to localization/**/*.ts are performed
via Weblate and that any EOF-only edits are included in that workflow.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: 4f5cf94c-ab30-49dd-b544-44e27638549e

📥 Commits

Reviewing files that changed from the base of the PR and between 3e4618a and 603be52.

📒 Files selected for processing (5)

localization/localization_de_LU.ts
localization/localization_fr_FR.ts
localization/localization_fr_LU.ts
localization/localization_sr_RS.ts
localization/localization_tr_TR.ts

fix: grammar corrections in localization files

3e4618a

- de_LU: Benutzerverzeichnis -> Benutzerliste - fr_FR: editez -> editiez (subjunctive) - fr_LU: n'a pas -> n'avez pas, editées -> editiez - sr_RS: ISTKAO typo, duplicated I i conjunction - tr_TR: improved Turkish phrasing

This comment has been minimized.

Sign in to view

codeant-ai Bot added the size:S This PR changes 10-29 lines, ignoring generated files label Apr 17, 2026

coderabbitai Bot reviewed Apr 17, 2026

View reviewed changes

Comment thread localization/localization_de_LU.ts Outdated

Comment thread localization/localization_fr_FR.ts Outdated

Comment thread localization/localization_fr_LU.ts Outdated

Comment thread localization/localization_sr_RS.ts Outdated

Comment thread localization/localization_tr_TR.ts Outdated

fix: apply CodeRabbit auto-fixes

603be52

Fixed 5 file(s) based on 5 unresolved review comments. Co-authored-by: CodeRabbit <noreply@coderabbit.ai>

coderabbitai Bot reviewed Apr 17, 2026

View reviewed changes

annejan merged commit f27df93 into main Apr 17, 2026
23 checks passed

annejan deleted the fix/localization-grammar-fixes branch April 17, 2026 02:45

This was referenced Apr 17, 2026

Translations update from Hosted Weblate #1018

Merged

chore: update localization skill #1022

Merged

chore: Some Turkish translation updates #1061

Merged

fix: Turkish localization — correct system tray, integrity, and re-encrypt translations #1070

Merged

Uh oh!

Conversation

nogeenhenk commented Apr 17, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

codeant-ai Bot commented Apr 17, 2026

Uh oh!

This comment has been minimized.

coderabbitai Bot commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Suggested labels

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

codeant-ai Bot commented Apr 17, 2026

Uh oh!

coderabbitai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fixes Applied Successfully

Uh oh!

kody-ai Bot commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Kody Review Complete

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nogeenhenk commented Apr 17, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 17, 2026 •

edited

Loading

coderabbitai Bot left a comment •

edited

Loading

coderabbitai Bot commented Apr 17, 2026 •

edited

Loading

kody-ai Bot commented Apr 17, 2026 •

edited

Loading