Skip to content

chore: rename keygenDialog/currentDir/tray → m_-prefixed (consistency)#1202

Merged
annejan merged 1 commit into
mainfrom
chore/rename-mainwindow-members-m-prefix
Apr 27, 2026
Merged

chore: rename keygenDialog/currentDir/tray → m_-prefixed (consistency)#1202
annejan merged 1 commit into
mainfrom
chore/rename-mainwindow-members-m-prefix

Conversation

@annejan
Copy link
Copy Markdown
Member

@annejan annejan commented Apr 27, 2026

Refactored the MainWindow class by renaming the following member variables to include an m_ prefix for consistency:

  • keygenDialog to m_keygenDialog
  • currentDir to m_currentDir
  • tray to m_tray

This change is purely a refactoring effort to align with established naming conventions and has no functional impact on the application.

The recent additions to MainWindow's member list (m_qtPass, m_grepMode,
m_initialShowDone, m_processOutputDock, etc) all use the m_-prefix
convention to mark instance state. The three older holdovers
(keygenDialog, currentDir, tray) didn't. Aligning them so a reader
scanning a method body can immediately see which identifiers are
member state versus locals/parameters/globals.

Pure rename — no behavioural change. Six member-access sites for
keygenDialog (skipping the unrelated string-literal "keygenDialog"
keys used by QtPassSettings::getDialogGeometry et al), seven for
currentDir, seven for tray; comments referring to "tray icon" /
"tray/icon settings" left as prose.
@kody-ai
Copy link
Copy Markdown

kody-ai Bot commented Apr 27, 2026

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Validate Business Logic: Ask Kody to validate your code against business rules by adding a comment with the @kody -v business-logic command.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug
Performance
Security
Business Logic

Access your configuration settings here.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 27, 2026

📝 Walkthrough

Walkthrough

Renamed three private member variables in MainWindow from unprefixed names (keygenDialog, tray, currentDir) to conventionally-prefixed names (m_keygenDialog, m_tray, m_currentDir). Updated all usages throughout the implementation file and the corresponding getter method.

Changes

Cohort / File(s) Summary
Member Variable Renaming
src/mainwindow.h, src/mainwindow.cpp
Refactored private member variables to use m_ naming prefix convention. Updated all references to keygenDialog, tray, and currentDir to their m_-prefixed equivalents, including the getKeygenDialog() getter method.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

size:S

Poem

🐰 With whiskers and cheer, I hop through the code,
Those variables now wear their m_ mode!
A naming convention so clean and so bright,
Makes encapsulation feel perfectly right.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: renaming three member variables to use m_ prefix for consistency. It is concise, specific, and clearly describes the primary modification.
Docstring Coverage ✅ Passed Docstring coverage is 80.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/rename-mainwindow-members-m-prefix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 28.015%. remained the same — chore/rename-mainwindow-members-m-prefix into main

@annejan annejan merged commit ac70f8e into main Apr 27, 2026
24 of 25 checks passed
@annejan annejan deleted the chore/rename-mainwindow-members-m-prefix branch April 27, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants