chore: rename keygenDialog/currentDir/tray → m_-prefixed (consistency)#1202
Conversation
The recent additions to MainWindow's member list (m_qtPass, m_grepMode, m_initialShowDone, m_processOutputDock, etc) all use the m_-prefix convention to mark instance state. The three older holdovers (keygenDialog, currentDir, tray) didn't. Aligning them so a reader scanning a method body can immediately see which identifiers are member state versus locals/parameters/globals. Pure rename — no behavioural change. Six member-access sites for keygenDialog (skipping the unrelated string-literal "keygenDialog" keys used by QtPassSettings::getDialogGeometry et al), seven for currentDir, seven for tray; comments referring to "tray icon" / "tray/icon settings" left as prose.
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
📝 WalkthroughWalkthroughRenamed three private member variables in MainWindow from unprefixed names ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Refactored the
MainWindowclass by renaming the following member variables to include anm_prefix for consistency:keygenDialogtom_keygenDialogcurrentDirtom_currentDirtraytom_trayThis change is purely a refactoring effort to align with established naming conventions and has no functional impact on the application.