test(passworddialog): nine widget tests for the previously-untested API

[annejan]

Summary

`PasswordDialog` had decent `setPassword`/`getPassword` round-trip coverage in `tst_ui.cpp` (4 tests + the 2 named `passwordDialog*` ones) but its other public API was largely untested. This PR fills that gap.

Tests added

Case	API exercised
`passwordDialogShowCheckboxTogglesEchoMode`	`on_checkBoxShow_stateChanged` — flips `QLineEdit::echoMode` Password ↔ Normal
`passwordDialogSetLengthUpdatesSpinBox`	`setLength(int)`
`passwordDialogSetPasswordCharTemplateUpdatesCombo`	`setPasswordCharTemplate(int)`
`passwordDialogUsePwgenDisablesTemplateSelector`	`usePwgen(bool)`
`passwordDialogSetPassPopulatesField`	`setPass(output)`
`passwordDialogSetAvailableTemplatesAppliesDefault`	`setAvailableTemplates(templates, defaultName)`
`passwordDialogCycleTemplateAdvancesToNext`	`cycleTemplate()` — creditcard → login
`passwordDialogCycleTemplateWrapsToFirst`	`cycleTemplate()` — login (last) wraps to creditcard
`passwordDialogCycleTemplateNoOpWhenEmpty`	`cycleTemplate()` with no registered templates is a no-op

Each test instantiates a real PasswordDialog (no Pass-singleton required — the dialog is independent of QtPassSettings::getPass), drives an input, and asserts on observable widget state via `findChild<T*>`.

Test plan

• `qmake6 -r && make -j4` clean
• `tests/auto/ui/tst_ui` — 55/55 (was 46, +9)
• clang-format applied

Includes

Added `QCheckBox`, `QComboBox`, `QHash`, `QLabel`, `QSpinBox` to the test file's include block for the newly addressed widget types.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Tests
  • Enhanced test coverage for password dialog functionality, including show/hide password toggle, length synchronization, character template selection, template cycling behavior, and password field operations.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: 0a6fe8d7-f6b6-42a8-93b3-11836d6fb45b

📥 Commits

Reviewing files that changed from the base of the PR and between bbc94a5 and ddfabf7.

📒 Files selected for processing (1)

• tests/auto/ui/tst_ui.cpp

---

📝 Walkthrough

Walkthrough

This change expands the tst_ui test suite with nine new PasswordDialog UI test cases covering echo-mode toggling, widget state synchronization (length and template selection), pwgen mode behavior, password field population, available template application, and template cycling including wraparound and empty-list handling.

Changes

PasswordDialog UI Test Suite

Layer / File(s)

Summary

PasswordDialog UI tests with headers and implementations tests/auto/ui/tst_ui.cpp

Qt checkbox, label, line edit, spinbox, and hash headers are added to support widget lookup and state assertions. Nine test method declarations cover echo-mode, length sync, template selection, pwgen disabling, setPass behavior, available templates, and template cycling. Implementations use findChild to locate widgets by objectName and verify expected state transitions after calling PasswordDialog methods.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

• IJHack/QtPass#1150: Adds new UI tests for PasswordDialog behaviors directly tied to PasswordDialog implementation changes (setPassword/getPassword/setTemplate and templateLines state).
• IJHack/QtPass#867: Adds QtTest cases exercising PasswordDialog slot-driven UI behavior, aligned with PasswordDialog header syntax updates.
• IJHack/QtPass#1082: Adds UI tests exercising PasswordDialog behaviors including template cycling and generated-password handling, overlapping with PasswordDialog code path changes.

Poem

🐰 A rabbit hops through dialog states,
Testing echo modes and checkbox fates,
Templates cycle, spin-boxes sync,
Each assertion brings code to the brink,
Nine tests now dance in QtPass delight! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: adding nine widget tests for PasswordDialog's previously-untested API.
Docstring Coverage	✅ Passed	Docstring coverage is 90.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch tests/passworddialog-gaps

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coveralls]

coverage: 32.59% (+0.4%) from 32.144% — tests/passworddialog-gaps into main