chore: NSHighResolutionCapable as a real plist boolean, not <string>True</string>#1483
Conversation
…rue</string>
CodeRabbit's recurring nit on every new test subdir we add: the
NSHighResolutionCapable key was being stored as <string>True</string>
instead of the boolean <true/> form Apple's plist DTD expects. Sweep
the project to fix it once.
11 plists touched:
- qtpass.plist (root, the canonical copy that main/qtpass.plist,
tests/auto/ui/qtpass.plist, and tests/auto/util/qtpass.plist all
symlink to)
- 10 free-standing copies in tests/auto/{configdialog, executor,
exportpublickeydialog, filecontent, importkeydialog, keygendialog,
model, passwordconfig, settings, trayicon}/qtpass.plist
Macros / templated values (CFBundleDisplayName etc.) untouched. No
build-time or run-time impact — these only feed the macOS .app bundle
Info.plist, but it makes future per-subdir nits go away.
NOT addressed: the existing duplicate <key>NSPrincipalClass</key> entry
in qtpass.plist (lines 26-29) is a different, pre-existing issue and
out of scope here.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
📝 WalkthroughWalkthroughThis PR corrects the data type of the ChangesProperty list type corrections
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
qtpass.plist (1)
26-29: 🧹 Nitpick | 🔵 TrivialInformational: Duplicate
NSPrincipalClasskey detected.Lines 26-27 and 28-29 define the same key twice. While plist parsers typically use the last value, duplicate keys violate the plist specification. This is noted as out of scope for this PR but may warrant cleanup in a future change.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@qtpass.plist` around lines 26 - 29, The plist contains a duplicate key entry for NSPrincipalClass with the same value NSApplication; remove the redundant key/value pair so NSPrincipalClass appears only once (keep a single <key>NSPrincipalClass</key> with its corresponding <string>NSApplication</string>), ensuring the plist conforms to the spec and avoids duplicate keys.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@qtpass.plist`:
- Around line 26-29: The plist contains a duplicate key entry for
NSPrincipalClass with the same value NSApplication; remove the redundant
key/value pair so NSPrincipalClass appears only once (keep a single
<key>NSPrincipalClass</key> with its corresponding
<string>NSApplication</string>), ensuring the plist conforms to the spec and
avoids duplicate keys.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: 990670c9-8257-419b-89c8-57482245b085
📒 Files selected for processing (11)
qtpass.plisttests/auto/configdialog/qtpass.plisttests/auto/executor/qtpass.plisttests/auto/exportpublickeydialog/qtpass.plisttests/auto/filecontent/qtpass.plisttests/auto/importkeydialog/qtpass.plisttests/auto/keygendialog/qtpass.plisttests/auto/model/qtpass.plisttests/auto/passwordconfig/qtpass.plisttests/auto/settings/qtpass.plisttests/auto/trayicon/qtpass.plist
|
coverage: 44.752%. remained the same — chore/plist-boolean-true into main |
2 participants
Summary
CodeRabbit's recurring nit on every new test subdir we add (most recently #1481): the `NSHighResolutionCapable` key in our `qtpass.plist` files is stored as `True` instead of the boolean `` form Apple's plist DTD expects. Sweep the project to fix it once so future per-subdir-PRs don't keep flagging it.
Files
11 plists touched (+1/-1 each):
What this affects
These plists template the macOS `.app` bundle's `Info.plist`. No Linux/Windows impact, no test-runtime impact. Just correctness per Apple's DTD.
Out of scope
The duplicate `NSPrincipalClass` entry in `qtpass.plist` (lines 26-29) is a different pre-existing issue. Left alone.
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
Release Notes