Skip to content

Potential fixes for 3 code quality findings#822

Merged
annejan merged 4 commits intomainfrom
ai-findings-autofix/src-usersdialog.cpp
Mar 28, 2026
Merged

Potential fixes for 3 code quality findings#822
annejan merged 4 commits intomainfrom
ai-findings-autofix/src-usersdialog.cpp

Conversation

@nogeenhenk
Copy link
Copy Markdown
Contributor

This PR applies 3/4 suggestions from code quality AI findings. 1 suggestion was skipped to avoid creating conflicts.

nogeenhenk and others added 4 commits March 28, 2026 15:51
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 28, 2026

Coverage Status

coverage: 18.397% (-0.007%) from 18.404%
when pulling 30ee50b on ai-findings-autofix/src-usersdialog.cpp
into 94bbe81 on main.

@annejan annejan marked this pull request as ready for review March 28, 2026 15:00
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 28, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 24.02%. Comparing base (94bbe81) to head (30ee50b).
⚠️ Report is 5 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/usersdialog.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #822      +/-   ##
==========================================
- Coverage   24.03%   24.02%   -0.02%     
==========================================
  Files          38       38              
  Lines        3016     3018       +2     
==========================================
  Hits          725      725              
- Misses       2291     2293       +2     
Flag Coverage Δ
qtpass 24.02% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@annejan annejan merged commit 6987680 into main Mar 28, 2026
17 of 19 checks passed
@annejan annejan deleted the ai-findings-autofix/src-usersdialog.cpp branch March 28, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants