Improve tests: remove empty initTestCase, add type checks, fix mkdir pattern#840
Merged
Improve tests: remove empty initTestCase, add type checks, fix mkdir pattern#840
Conversation
nogeenhenk
force-pushed
the
fix/test-improvements
branch
2 times, most recently
from
2580d38 to
84e0c70
Compare
…pattern - Remove empty initTestCase() from 5 test files - Add type validation before toString() (canConvert<QString> for Qt5/6 compat) - Fix mkdir pattern to check directory exists after mkdir
nogeenhenk
force-pushed
the
fix/test-improvements
branch
from
84e0c70 to
3f74fbf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initTestCase()from 5 test files (executor, filecontent, model, simpletransaction, util)toString()indataRemovesGpgExtensiontest|| QDir(...).exists())Testing