Merged
Conversation
Add paths filters to skip CI when irrelevant files change: - ccpp.yml: src/**, tests/**, Qt files, localization, icons, docs - codeql.yml: only C++ code - publiccode.yml: only publiccode.yml - reuse.yml: unfiltered (repo-wide compliance check) Also adds merge_group trigger (without branches filter). Note: paths filtering is only used for non-required checks.
- Remove paths filter from workflow triggers - Add dorny/paths-filter to detect changed files - Make expensive jobs conditional based on changes - merge_group always runs all jobs This avoids the 'pending required check' issue by keeping workflows always running but skipping expensive jobs internally.
- Add changes job to detect relevant file changes - Make expensive jobs conditional based on changes - merge_group and tags always run builds - Tags still trigger builds for releases
- Add no-op job to each workflow that runs when no relevant files changed - No-op jobs emit a success result instead of being skipped - This ensures required checks always report (success or skipped, never pending) This completes the fix for issue where path filtering caused required checks to stay pending.
- Remove job-level 'if' condition that caused SKIPPED status - Add step-level conditionals to skip heavy work when no changes - Job always reports SUCCESS instead of being skipped - This fixes required checks staying pending
- Remove job-level 'if' conditions that caused SKIPPED status - Add step-level conditionals to skip heavy work when no changes - Jobs always report SUCCESS instead of being skipped - This fixes required checks staying pending
- copyDir was never called from production code (only tests) - Added in 2017 by Anne Jan Brouwer, purpose unclear - Tests were added later but no production usage ever - Fixes issue #842
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the unused
Util::copyDirfunction from the codebase.Background
From issue #842:
History
0d4300659- "Housekeeping")Investigation
Checked usage of all Util static functions:
Changes
copyDirdeclaration fromsrc/util.hcopyDirimplementation fromsrc/util.cpptests/auto/util/tst_util.cppTesting
Build and run tests to verify nothing is broken.
Closes #842