fix: verify temp file cleanup in test

[nogeenhenk]

Summary

Verify that QFile::remove() succeeds in the findBinaryInPathTempExecutableInTempDir test to avoid leaving test files in PATH directories.

Changes

• Added verification that file cleanup succeeded
• Uses QVERIFY2() with descriptive failure message

Testing

• Local tests pass (55 passed, 1 skipped)

Fixes CodeRabbit AI finding.

Summary by CodeRabbit

• Tests
  • Enhanced test cleanup to verify successful removal of temporary files and provide detailed diagnostic information when cleanup fails, improving test robustness and troubleshooting capabilities.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: e9f77a81-ffe6-4e74-bb17-f41b0198a231

📥 Commits

Reviewing files that changed from the base of the PR and between 2a964e2 and 440a300.

📒 Files selected for processing (1)

• tests/auto/util/tst_util.cpp

---

📝 Walkthrough

Walkthrough

A test cleanup operation now verifies temporary file removal succeeds, adding an assertion that fails the test with diagnostic output if the executable file cannot be deleted.

Changes

Cohort / File(s)	Summary
Test Cleanup Verification tests/auto/util/tst_util.cpp	Modified cleanup step in findBinaryInPathTempExecutableInTempDir() to capture the return value of QFile::remove() and verify success with a QVERIFY2 assertion that includes the failed path in the diagnostic message.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Temporary files cleanup with care,
Now assertions declare, "Please don't despair!"
When deletion might fail, we'll quickly know,
With paths in the message—a helpful show! ✓

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix: verify temp file cleanup in test' directly and clearly summarizes the main change—adding verification that temporary file cleanup succeeds in a test.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/test-cleanup-verification

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coveralls]

coverage: 19.722%. remained the same
when pulling 440a300 on fix/test-cleanup-verification
into 2a964e2 on main.