fix: address AI findings - SLOT macro, dead code, magic numbers

[nogeenharrie]

User description

Summary

• qpushbuttonwithclipboard: use new-style connect instead of SLOT macro
• qpushbuttonasqrcode: remove unused changeIconDefault method and slot
• configdialog: reset background color in else branches, use PasswordConfiguration::CUSTOM

---

CodeAnt-AI Description

Fix validation and password template behavior in the settings dialog

What Changed

• Required-field highlights now clear as soon as a value is valid, instead of leaving the field marked in red
• The custom password characters field is enabled only when the custom template is selected
• Clipboard copy buttons still show the temporary copied-state icon and then return to the default icon; an unused QR button action was removed

Impact

✅ Clearer form validation
✅ Fewer confusing settings errors
✅ Correct custom password entry behavior

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Summary by CodeRabbit

• Bug Fixes

  • Dialog validation now properly clears visual feedback (background and tooltip) on valid entries.

• Changes

  • Updated password character input selection logic for improved robustness.

• Removed Features

  • Removed icon reset functionality from button component.

[codeant-ai]

CodeAnt AI is reviewing your PR.

[coderabbitai]

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (13)

• icons/applications-system.svg is excluded by !**/*.svg
• icons/document-new.svg is excluded by !**/*.svg
• icons/document-properties.svg is excluded by !**/*.svg
• icons/edit-clear.svg is excluded by !**/*.svg
• icons/edit-copy.svg is excluded by !**/*.svg
• icons/edit-delete.svg is excluded by !**/*.svg
• icons/folder-new.svg is excluded by !**/*.svg
• icons/go-bottom.svg is excluded by !**/*.svg
• icons/go-top.svg is excluded by !**/*.svg
• icons/hide.svg is excluded by !**/*.svg
• icons/qrcode.svg is excluded by !**/*.svg
• icons/view.svg is excluded by !**/*.svg
• icons/x-office-address-book.svg is excluded by !**/*.svg

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: 0cc138b9-7355-4a4c-a9bb-f73665bfc795

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

📝 Walkthrough

Walkthrough

The pull request refactors Qt signal-slot connections and validation logic across multiple files. It removes the unused changeIconDefault() slot from QPushButtonAsQRCode, updates a timer callback in QPushButtonWithClipboard to use type-safe function pointers, and replaces hardcoded indices with enum values in dialog validation.

Changes

Cohort / File(s)	Summary
Button slot removal src/qpushbuttonasqrcode.h, src/qpushbuttonasqrcode.cpp	Removed the changeIconDefault() private slot declaration and implementation from the QPushButtonAsQRCode class.
Timer callback modernization src/qpushbuttonwithclipboard.cpp	Updated QTimer::singleShot callback from string-based slot invocation to type-safe member function pointer syntax.
Validation logic refinement src/configdialog.cpp	Explicitly clear item background and tooltip in validation success path; replaced hardcoded index check with enum constant comparison for password character selector.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• fix: use theme colors for button icons #949: Modifies the same QPushButton helper classes (QPushButtonAsQRCode, QPushButtonWithClipboard) for icon and visual adjustments.
• style: use slots/signals instead of Q_SLOTS/Q_SIGNALS #867: Updates Qt signals and slots syntax in the same helper class headers and implementations.

Suggested labels

size:XS

Poem

🐰 A slot removed, a pointer fine,
No more hardcoded numbers in the line,
Type-safety wins with modern grace,
The code now runs at a cleaner pace!

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly corresponds to the three main changes: replacing SLOT macro usage, removing dead code (changeIconDefault), and replacing magic numbers with constants (PasswordConfiguration::CUSTOM).
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/address-ai-findings

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codeant-ai]

CodeAnt AI finished reviewing your PR.

[coveralls]

Coverage is 21.06% — fix/address-ai-findings into main. No base build found for main.