fix: address AI findings in qtpasssettings#960
Merged
Conversation
Contributor
|
CodeAnt AI is reviewing your PR. |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughUpdated internal implementation of QtPassSettings: replaced Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
codeant-ai
Bot
added
the
size:S
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/qtpasssettings.cpp`:
- Around line 297-304: QtPassSettings::setUsePass currently calls
pass.reset(getRealPass()) / pass.reset(getImitatePass()) which reuses pointers
owned elsewhere and causes double-free; change the ownership semantics so
setUsePass takes ownership safely — either make getRealPass() and
getImitatePass() return a std::unique_ptr (or return by value) and then assign
via move (e.g., pass = getRealPass()), or if the getters must return raw
pointers return a fresh copy and call pass.reset(new ...) to own a distinct
object; update the getPass()/getRealPass()/getImitatePass() implementations
accordingly to eliminate shared ownership of the same pointer.
- Around line 171-183: The current getPass() causes double ownership by calling
pass.reset(getRealPass()/getImitatePass()) where getRealPass() returns
realPass.data() (owned by QScopedPointer<RealPass> realPass), so both realPass
and pass will delete the same object; change the ownership model by making
member pass a non-owning raw Pass* (revert from QScopedPointer) and in getPass()
assign pass = getRealPass() or pass = getImitatePass() (do not call reset or
take ownership), keep the existing null check and call pass->init() only when
pass is non-null, and ensure any code that previously relied on pass owning
lifetime is updated to use the real QScopedPointer owners (realPass/imitatePass)
instead of pass.
In `@src/qtpasssettings.h`:
- Around line 49-51: The header introduced double-ownership by making "pass" a
QScopedPointer<Pass>; revert "pass" to a non-owning raw pointer (Pass*) so it
does not try to take ownership of objects returned by getRealPass() /
getImitatePass(), or alternatively refactor ownership so only one QScopedPointer
owns the object and other accessors return raw pointers/references; locate the
declarations static QScopedPointer<Pass> pass, static QScopedPointer<RealPass>
realPass, static QScopedPointer<ImitatePass> imitatePass and the uses of
pass.reset(getRealPass()) / pass.reset(getImitatePass()) and change "pass" to
Pass* (and remove/reset calls that transfer ownership) or convert
realPass/imitatePass to unique owners and make pass a non-owning alias
consistently.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: 22a2d228-c74d-4c3e-acd5-9e3b6a60b5a6
📒 Files selected for processing (2)
src/qtpasssettings.cppsrc/qtpasssettings.h
Contributor
|
CodeAnt AI finished reviewing your PR. |
nogeenharrie
force-pushed
the
fix/qtpasssettings-ai-findings
branch
from
3cb933e to
49632af
Compare
|
Coverage is 20.907% — fix/qtpasssettings-ai-findings into main. No base build found for |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/qtpasssettings.cpp`:
- Around line 297-303: The current setUsePass in QtPassSettings assigns pass to
getRealPass()/getImitatePass(), which creates an uninitialized backend alias and
bypasses the lazy init in getPass(); change setUsePass (method
QtPassSettings::setUsePass) to not bind pass directly but clear/reset the
existing pass pointer/alias (e.g. set pass to null/clear cached backend) after
updating the stored setting (getInstance()->setValue(SettingsConstants::usePass,
usePass)) so that subsequent calls to QtPassSettings::getPass() will go through
the existing select-and-init path (invoking init()) and return a fully
initialized backend; ensure references to getRealPass/getImitatePass are only
used inside getPass/init logic, not assigned here.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: 3c563513-68e1-4038-bd5e-fcc767da4c23
📒 Files selected for processing (2)
src/qtpasssettings.cppsrc/qtpasssettings.h
- Keep Pass* as non-owning pointer to avoid double-free - Replace foreach with std::as_const range-based for loops - Add null check before calling pass->init() - Clear pass pointer in setUsePass() so next getPass() reinitializes
nogeenharrie
force-pushed
the
fix/qtpasssettings-ai-findings
branch
from
49632af to
9966c6c
Compare
This was referenced Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Summary
CodeAnt-AI Description
Prevent crashes when switching password backends and clean up settings handling
What Changed
Impact
✅ Fewer startup crashes✅ Safer backend switching✅ More reliable settings loading💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.
Summary by CodeRabbit