-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Proposal) Link receipts/ documents from posting journal rows #1034
Labels
Projects
Comments
How would you feel about storing these links in the database? Currently, the references are stored in |
That sounds like a good idea to me. It would reduce a lot of calculations
or complexity on displaying the links.
This should consider if the link will be state based (displaying receipt
modal) or URL based.
…On 8 Dec 2016 13:11, "Jonathan Niles" ***@***.***> wrote:
How would you feel about storing these links in the database? Currently,
the references are stored in reference_map, with a (uuid, text) pair. We
could easily expand this to (uuid, text, link).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1034 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACtnnNhVExFTiSNkBLj4_k6TVW0ztQiZks5rF_PmgaJpZM4LHtlO>
.
|
6 tasks
bors bot
added a commit
that referenced
this issue
Sep 25, 2017
2085: refactor: Posting Journal and Associated Tools r=mbayopanda a=jniles This Pull Request finalizes the refactor of the Posting Journal and associated modules. The commit history contains a full list of changes. In brief: 1. Editing has been moved out into a modal. By breaking out the editing code, the complexity of the Posting Journal is reduced. It also enforces editing a single transaction at a time. 2. The Trial Balance has moved into Stored Procedures. This separates the JS code from the SQL code and speeds up the execution of the Trail Balance slightly. 3. The Trial Balance no longer reloads data between `$state` changes. The modal is much more snappy than previous. 4. Links to the receipts/documents/patients associated with each transaction are embedded in the Posting Journal. This makes it easy to find the details associated with a given transaction. 5. The Posting Journal is able to load "posted" transactions. To accommodate this, the Posting Journal footer has been improved to show the number of unposted or posted transactions. Additionally, the "Posted Journal" module has been removed. There have been a number of miscellaneous bug fixes addressed as well. As with any change, this may introduce new bugs specific to the changes listed above. Partially addresses #1432. Closes #1034. Closes #1163. Closes #1402. Closes #1500. Closes #1640. Closes #1659. Closes #1716. Closes #1717. Closes #1724. Closes #1832. Closes #1839. Closes #1921. Closes #1928. Closes #1934. Closes #1943. Closes #1944. Closes #1948. Closes #1950. Closes #1961. Closes #2031. Closes #2041. --- ### TODO Before Merge - [x] Ensure all keys are translated into both French and English - [x] Ensure tests pass - [x] Make sure all filters/links work on Posting Journal page. - [x] Make sure all filters/links work on the Trial Balance - [x] Ensure all editors work as expected. - [x] Ensure that new code passes lint checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently recipients (Debtors/ Creditors) and References (Invoices/ Cash Payments etc.) are shown in the posting journal as well formatted strings.
I propose we make these links to documents and entities within BHIMA. This would provide valuable context for the transaction.
Current rows
![link documents](https://cloud.githubusercontent.com/assets/2844572/21008220/0d18e090-bd41-11e6-85c1-275731979280.PNG)
Each of these reference patient invoices or patients themselves. Linking to the invoice receipts or patient cards would allow an accountant to directly view relevant notes/ users/ inventory items processed etc. in a transaction.
The text was updated successfully, but these errors were encountered: