Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(posting journal) scroll to edited transaction #1943

Closed
mbayopanda opened this issue Aug 9, 2017 · 2 comments · Fixed by #2085
Closed

fix(posting journal) scroll to edited transaction #1943

mbayopanda opened this issue Aug 9, 2017 · 2 comments · Fixed by #2085
Assignees
@jniles

Comments

@mbayopanda
Copy link
Contributor

After editing a transaction it is difficult to find the edited transaction line directly.

This issue is about to scroll or add highlight to the edited transaction
@jniles jniles self-assigned this Aug 9, 2017
@jniles
Copy link
Collaborator

jniles commented Aug 9, 2017

I've been working on this and got it working on my own branch. It'll be introduced with a PR soon.

@sfount
Copy link
Contributor

sfount commented Aug 9, 2017

To add to this, I have been working on #1832. This feature allows the transaction to be edited away from the journal's context - the values in the posting will then be updated but the user will be looking at exactly the same lines that they were before editing without any scrolling.

@jniles jniles mentioned this issue Sep 20, 2017
Merged
6 tasks
bors bot added a commit that referenced this issue Sep 25, 2017
@bors
Merge #2085
afc9ee2 
2085: refactor: Posting Journal and Associated Tools r=mbayopanda a=jniles

This Pull Request finalizes the refactor of the Posting Journal and associated modules.  The commit history contains a full list of changes.  In brief:
 1. Editing has been moved out into a modal.  By breaking out the editing code, the complexity of the Posting Journal is reduced.  It also enforces editing a single transaction at a time.
 2. The Trial Balance has moved into Stored Procedures.  This separates the JS code from the SQL code and speeds up the execution of the Trail Balance slightly.
 3. The Trial Balance no longer reloads data between `$state` changes.  The modal is much more snappy than previous.
 4. Links to the receipts/documents/patients associated with each transaction are embedded in the Posting Journal.  This makes it easy to find the details associated with a given transaction.
 5. The Posting Journal is able to load "posted" transactions.  To accommodate this, the Posting Journal footer has been improved to show the number of unposted or posted transactions.  Additionally, the "Posted Journal" module has been removed.

There have been a number of miscellaneous bug fixes addressed as well.  As with any change, this may introduce new bugs specific to the changes listed above.

Partially addresses #1432.

Closes #1034.
Closes #1163.
Closes #1402.
Closes #1500.
Closes #1640.
Closes #1659.
Closes #1716.
Closes #1717.
Closes #1724.
Closes #1832.
Closes #1839.
Closes #1921.
Closes #1928.
Closes #1934.
Closes #1943.
Closes #1944.
Closes #1948.
Closes #1950.
Closes #1961.
Closes #2031.
Closes #2041.

---

### TODO Before Merge
 - [x] Ensure all keys are translated into both French and English
 - [x] Ensure tests pass
 - [x] Make sure all filters/links work on Posting Journal page.
 - [x] Make sure all filters/links work on the Trial Balance
 - [x] Ensure all editors work as expected.
 - [x] Ensure that new code passes lint checks.
@bors bors bot closed this as completed in #2085 Sep 25, 2017
bors bot added a commit that referenced this issue Feb 25, 2020
@bors @dependabot
Merge #4192
f6fc528 
4192: chore(deps): bump nokogiri from 1.10.4 to 1.10.8 in /docs r=jniles a=dependabot[bot]

Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.10.4 to 1.10.8.
<details>
<summary>Release notes</summary>

*Sourced from [nokogiri's releases](https://github.com/sparklemotion/nokogiri/releases).*

> ## 1.10.8 / 2020-02-10
> 
> ### Security
> 
> [MRI] Pulled in upstream patch from libxml that addresses CVE-2020-7595. Full details are available in [#1992](https://github-redirect.dependabot.com/sparklemotion/nokogiri/issues/1992). Note that this patch is not yet (as of 2020-02-10) in an upstream release of libxml.
> 
> 
> 
> ## 1.10.7 / 2019-12-03
> 
> ### Bug
> 
> * [MRI] Ensure the patch applied in v1.10.6 works with GNU `patch`. [#1954](https://github-redirect.dependabot.com/sparklemotion/nokogiri/issues/1954)
> 
> 
> 
> ## 1.10.6 / 2019-12-03
> 
> ### Bug
> 
> * [MRI] Fix FreeBSD installation of vendored libxml2. [#1941, [#1953](https://github-redirect.dependabot.com/sparklemotion/nokogiri/issues/1953)] (Thanks, [@&#8203;nurse](https://github.com/nurse)!)
> 
> 
> 
> ## 1.10.5 / 2019-10-31
> 
> ### Dependencies
> 
> * [MRI] vendored libxml2 is updated from 2.9.9 to 2.9.10
> * [MRI] vendored libxslt is updated from 1.1.33 to 1.1.34
> 
> 
</details>
<details>
<summary>Changelog</summary>

*Sourced from [nokogiri's changelog](https://github.com/sparklemotion/nokogiri/blob/master/CHANGELOG.md).*

> ## 1.10.8 / 2020-02-10
> 
> ### Security
> 
> [MRI] Pulled in upstream patch from libxml that addresses CVE-2020-7595. Full details are available in [#1992](https://github-redirect.dependabot.com/sparklemotion/nokogiri/issues/1992). Note that this patch is not yet (as of 2020-02-10) in an upstream release of libxml.
> 
> 
> ## 1.10.7 / 2019-12-03
> 
> ### Fixed
> 
> * [MRI] Ensure the patch applied in v1.10.6 works with GNU `patch`. [[#1954](https://github-redirect.dependabot.com/sparklemotion/nokogiri/issues/1954)]
> 
> 
> ## 1.10.6 / 2019-12-03
> 
> ### Fixed
> 
> * [MRI] Fix FreeBSD installation of vendored libxml2. [[#1941](https://github-redirect.dependabot.com/sparklemotion/nokogiri/issues/1941), [#1953](https://github-redirect.dependabot.com/sparklemotion/nokogiri/issues/1953)] (Thanks, [@&#8203;nurse](https://github.com/nurse)!)
> 
> 
> ## 1.10.5 / 2019-10-31
> 
> ### Security
> 
> [MRI] Vendored libxslt upgraded to v1.1.34 which addresses three CVEs for libxslt:
> 
> * CVE-2019-13117
> * CVE-2019-13118
> * CVE-2019-18197
> * CVE-2019-19956
> 
> More details are available at [#1943](https://github-redirect.dependabot.com/sparklemotion/nokogiri/issues/1943).
> 
> 
> ### Dependencies
> 
> * [MRI] vendored libxml2 is updated from 2.9.9 to 2.9.10
> * [MRI] vendored libxslt is updated from 1.1.33 to 1.1.34
</details>
<details>
<summary>Commits</summary>

- [`6ce10d1`](sparklemotion/nokogiri@6ce10d1) version bump to v1.10.8
- [`2320f5b`](sparklemotion/nokogiri@2320f5b) update CHANGELOG for v1.10.8
- [`4a77fdb`](sparklemotion/nokogiri@4a77fdb) remove patches from the hoe Manifest
- [`570b6cb`](sparklemotion/nokogiri@570b6cb) update to use rake-compiler ~1.1.0
- [`2cdb68e`](sparklemotion/nokogiri@2cdb68e) backport libxml2 patch for CVE-2020-7595
- [`e6b3229`](sparklemotion/nokogiri@e6b3229) version bump to v1.10.7
- [`4f9d443`](sparklemotion/nokogiri@4f9d443) update CHANGELOG
- [`80e67ef`](sparklemotion/nokogiri@80e67ef) Fix the patch from [#1953](https://github-redirect.dependabot.com/sparklemotion/nokogiri/issues/1953) to work with both `git` and `patch`
- [`7cf1b85`](sparklemotion/nokogiri@7cf1b85) Fix typo in generated metadata
- [`d76180d`](sparklemotion/nokogiri@d76180d) add gem metadata
- Additional commits viewable in [compare view](sparklemotion/nokogiri@v1.10.4...v1.10.8)
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=nokogiri&package-manager=bundler&previous-version=1.10.4&new-version=1.10.8)](https://help.github.com/articles/configuring-automated-security-fixes)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/IMA-WorldHealth/bhima/network/alerts).

</details>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Posting Journal and Associated Tools IMA-WorldHealth/bhima
3 participants
@jniles @sfount @mbayopanda