Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(design) Journal Module #1432

Closed
sfount opened this issue Mar 28, 2017 · 2 comments
Closed

(design) Journal Module #1432

sfount opened this issue Mar 28, 2017 · 2 comments
Labels
design

Comments

@sfount
Copy link
Contributor

sfount commented Mar 28, 2017 •
edited
Loading

This proposal follows on from #1241 with specific details on how this could be accomplished.

Objectives of the Journal:

  • View all financial transactions in the system
  • 'Post' records that are verified/ complete (view only unposted records to keep on top of this process)
  • Correct mistakes on transactions that have not been posted/ finalised
  • Provide a view into any of the billing entities within BHIMA
    • Patients
    • Invoices
    • Cash Payments
    • Vouchers
    • Accounts
    • Periods
  • (optional) Add a comment/ note to any line in the journal, filter on these notes to have custom views into the data
  • Ability to quickly export any group of transactions/ rows to CSV to be manipulated in excel

Technical objectives of the Journal:

  • Remember your exact configuration settings
    The journal is a complicated module and it is frustrating to constantly need to resize, move and show/ hide columns according to your required configuration
  • Responsive load times
  • Tested filter/ grouping functionality
  • Default and custom filters
    • Transaction date default filter
    • Posted/ not posted default filter
    • Other custom filters
  • Allow optimised custom filters
    • Only show transactions relating to invoices
    • Only show transactions relating to cash payments
    • Only show transactions relating to vouchers

Work focus:

  • Performance - ensuring that features/ refactors applied to the journal can be run on low end hardware
  • Functionality - common questions asked by an accountant should be able to be researched using the journal module

Required steps to implement the Journal:

  • Remove additional modules that require maintenance
    • Remove posted journal - this module will require exactly the same
    • Change structure of current General Ledger (all research for transactions should be through the journal)
  • Formally propose migration of General Ledger to report structure
    • Propose design for reports interactively linking to each other (Through HTML preview?)
  • [Requires Issue] Research saving ui-grid state
  • [Requires Issue] Refactor posting journal export to CSV
  • [Requires Issue] Validate posting journal edits on save
  • [Requires Issue] Split journal filters into default and custom filters
@sfount sfount added the design label Mar 28, 2017
@jniles
Copy link
Collaborator

jniles commented Apr 18, 2017 •
edited
Loading

  1. Research ui-grid save state - Make use of UI-Grid save state across registries/ tools #1050.
  2. Validating Posting Journal Edits - Complete validate Transaction with #1501.
  3. Refactoring Posting Journal Export to CSV - Export Transactions from Journals and General ledger #1506.

@sfount sfount mentioned this issue Aug 9, 2017
Closed
@sfount sfount mentioned this issue Aug 30, 2017
Closed
@jniles jniles mentioned this issue Sep 20, 2017
Merged
6 tasks
bors bot added a commit that referenced this issue Sep 25, 2017
@bors
Merge #2085
afc9ee2 
2085: refactor: Posting Journal and Associated Tools r=mbayopanda a=jniles

This Pull Request finalizes the refactor of the Posting Journal and associated modules.  The commit history contains a full list of changes.  In brief:
 1. Editing has been moved out into a modal.  By breaking out the editing code, the complexity of the Posting Journal is reduced.  It also enforces editing a single transaction at a time.
 2. The Trial Balance has moved into Stored Procedures.  This separates the JS code from the SQL code and speeds up the execution of the Trail Balance slightly.
 3. The Trial Balance no longer reloads data between `$state` changes.  The modal is much more snappy than previous.
 4. Links to the receipts/documents/patients associated with each transaction are embedded in the Posting Journal.  This makes it easy to find the details associated with a given transaction.
 5. The Posting Journal is able to load "posted" transactions.  To accommodate this, the Posting Journal footer has been improved to show the number of unposted or posted transactions.  Additionally, the "Posted Journal" module has been removed.

There have been a number of miscellaneous bug fixes addressed as well.  As with any change, this may introduce new bugs specific to the changes listed above.

Partially addresses #1432.

Closes #1034.
Closes #1163.
Closes #1402.
Closes #1500.
Closes #1640.
Closes #1659.
Closes #1716.
Closes #1717.
Closes #1724.
Closes #1832.
Closes #1839.
Closes #1921.
Closes #1928.
Closes #1934.
Closes #1943.
Closes #1944.
Closes #1948.
Closes #1950.
Closes #1961.
Closes #2031.
Closes #2041.

---

### TODO Before Merge
 - [x] Ensure all keys are translated into both French and English
 - [x] Ensure tests pass
 - [x] Make sure all filters/links work on Posting Journal page.
 - [x] Make sure all filters/links work on the Trial Balance
 - [x] Ensure all editors work as expected.
 - [x] Ensure that new code passes lint checks.
@jniles
Copy link
Collaborator

jniles commented Jan 19, 2018

Fascinatingly, I think all of these are actually completed in the system. Let me know if anything is missing and I'll re-open.

@jniles jniles closed this as completed Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jniles @sfount