proposal: remove the grouped transaction view from the TrialBalance #1716

jniles · 2017-05-31T10:38:11Z

The Trial Balance allows a user to view all the transactions that are currently selected. This makes the page excessively heavy, and the view doesn't give enough information to resolve several classes of errors (dates in the wrong period, etc) since it only shows ~4 columns. Furthermore, to resolve these issues, a user will need to go back to the Journal anyway.

I propose that we remove this functionality. I cannot find an issue proposing it to understand it's advantages. #585 only describes the error modal and an initial design for #1559.

Remove it has the following advantages:

Easier $state management - no need to pass Mb of transactions back and forth.
Cleaner TB API - The Trial Balance only needs to know the trans_id for display and record_uuid for processing.
Lighter weight ui-grid - we can remove the ui-grid grouping functionality, plus all imports needed by it since this is the functionality which uses it.
Simpler UX - For a user, it greatly simplifies the procedure. One page is for looking at account balances, another is for errors. Both can be used to clear the Trial Balance and return to the Journal for edits.

The text was updated successfully, but these errors were encountered:

This commit refactors the trial balance to show all the trial balance details in the Journal, rather than trying to render a grouped ui-grid on top of another grouped ui-grid. Currently, this has some drawbacks: 1. Because the filtering is done on the server, this requires an additional round-trip to the server. We could reasonably easily implement an inline-filter to take care of this, but it isn't a pattern we've followed so far. 2. Destroys the previous filters; this may not be necessarily understood by the user. We can revert this behavior with an angular.merge() of the two filters (cached and $state defined). Partially addresses #1163. Closes #1716.

This commit refactors the trial balance to show all the trial balance details in the Journal, rather than trying to render a grouped ui-grid on top of another grouped ui-grid. Currently, this has some drawbacks: 1. Because the filtering is done on the server, this requires an additional round-trip to the server. We could reasonably easily implement an inline-filter to take care of this, but it isn't a pattern we've followed so far. 2. Destroys the previous filters; this may not be necessarily understood by the user. We can revert this behavior with an angular.merge() of the two filters (cached and $state defined). Partially addresses IMA-WorldHealth#1163. Closes IMA-WorldHealth#1716.

This commit completely rewrites the Trail Balance removing the old multi-controller headers and replacing it with a single modal controller and substate controllers for the modal body. It also introduces the Trial Balance Service that interacts with the server to load the Trial Balance. Key Differences/Features: 1. Data is loaded a single time - no additional requests are made for data-by-account. 2. Instantaneously switching between error and overview states. 3. More room on the UI grid display 4. ui-grid complexity reduce by removing grid grouping and features. 5. [IN PROGRESS] Links to filter the journal based on the account and transaction. Since all data is loaded on startup, it should remove all issues reported in IMA-WorldHealth#1839. Closes IMA-WorldHealth#1716. Closes IMA-WorldHealth#1163. Closes IMA-WorldHealth#1839.

This commit refactors the trial balance to show all the trial balance details in the Journal, rather than trying to render a grouped ui-grid on top of another grouped ui-grid. Currently, this has some drawbacks: 1. Because the filtering is done on the server, this requires an additional round-trip to the server. We could reasonably easily implement an inline-filter to take care of this, but it isn't a pattern we've followed so far. 2. Destroys the previous filters; this may not be necessarily understood by the user. We can revert this behavior with an angular.merge() of the two filters (cached and $state defined). Partially addresses #1163. Closes #1716.

This commit completely rewrites the Trail Balance removing the old multi-controller headers and replacing it with a single modal controller and substate controllers for the modal body. It also introduces the Trial Balance Service that interacts with the server to load the Trial Balance. Key Differences/Features: 1. Data is loaded a single time - no additional requests are made for data-by-account. 2. Instantaneously switching between error and overview states. 3. More room on the UI grid display 4. ui-grid complexity reduce by removing grid grouping and features. 5. [IN PROGRESS] Links to filter the journal based on the account and transaction. Since all data is loaded on startup, it should remove all issues reported in #1839. Closes #1716. Closes #1163. Closes #1839.