(bug) Trial Balance initialises with no data #1839
Assignees
Labels
Comments
|
This is a really difficult one to track down - I initially noticed this, but couldn't get it to reproduce in a local environment. I imagine it has something to do with the ordering of HTTP requests and painting of the ui-grid. Somehow the Trial Balance doesn't repaint data if it takes a while to load. |
sfount
changed the title
jniles
added a commit
to jniles/bhima
that referenced
this issue
Aug 16, 2017
This commit completely rewrites the Trail Balance removing the old multi-controller headers and replacing it with a single modal controller and substate controllers for the modal body. It also introduces the Trial Balance Service that interacts with the server to load the Trial Balance. Key Differences/Features: 1. Data is loaded a single time - no additional requests are made for data-by-account. 2. Instantaneously switching between error and overview states. 3. More room on the UI grid display 4. ui-grid complexity reduce by removing grid grouping and features. 5. [IN PROGRESS] Links to filter the journal based on the account and transaction. Since all data is loaded on startup, it should remove all issues reported in IMA-WorldHealth#1839. Closes IMA-WorldHealth#1716. Closes IMA-WorldHealth#1163. Closes IMA-WorldHealth#1839.
sfount
pushed a commit
that referenced
this issue
Aug 17, 2017
This commit completely rewrites the Trail Balance removing the old multi-controller headers and replacing it with a single modal controller and substate controllers for the modal body. It also introduces the Trial Balance Service that interacts with the server to load the Trial Balance. Key Differences/Features: 1. Data is loaded a single time - no additional requests are made for data-by-account. 2. Instantaneously switching between error and overview states. 3. More room on the UI grid display 4. ui-grid complexity reduce by removing grid grouping and features. 5. [IN PROGRESS] Links to filter the journal based on the account and transaction. Since all data is loaded on startup, it should remove all issues reported in #1839. Closes #1716. Closes #1163. Closes #1839.
jniles
added a commit
that referenced
this issue
Sep 15, 2017
This commit completely rewrites the Trail Balance removing the old multi-controller headers and replacing it with a single modal controller and substate controllers for the modal body. It also introduces the Trial Balance Service that interacts with the server to load the Trial Balance. Key Differences/Features: 1. Data is loaded a single time - no additional requests are made for data-by-account. 2. Instantaneously switching between error and overview states. 3. More room on the UI grid display 4. ui-grid complexity reduce by removing grid grouping and features. 5. [IN PROGRESS] Links to filter the journal based on the account and transaction. Since all data is loaded on startup, it should remove all issues reported in #1839. Closes #1716. Closes #1163. Closes #1839.
jniles
added a commit
that referenced
this issue
Sep 18, 2017
This commit completely rewrites the Trail Balance removing the old multi-controller headers and replacing it with a single modal controller and substate controllers for the modal body. It also introduces the Trial Balance Service that interacts with the server to load the Trial Balance. Key Differences/Features: 1. Data is loaded a single time - no additional requests are made for data-by-account. 2. Instantaneously switching between error and overview states. 3. More room on the UI grid display 4. ui-grid complexity reduce by removing grid grouping and features. 5. [IN PROGRESS] Links to filter the journal based on the account and transaction. Since all data is loaded on startup, it should remove all issues reported in #1839. Closes #1716. Closes #1163. Closes #1839.
jniles
added a commit
that referenced
this issue
Sep 19, 2017
This commit completely rewrites the Trail Balance removing the old multi-controller headers and replacing it with a single modal controller and substate controllers for the modal body. It also introduces the Trial Balance Service that interacts with the server to load the Trial Balance. Key Differences/Features: 1. Data is loaded a single time - no additional requests are made for data-by-account. 2. Instantaneously switching between error and overview states. 3. More room on the UI grid display 4. ui-grid complexity reduce by removing grid grouping and features. 5. [IN PROGRESS] Links to filter the journal based on the account and transaction. Since all data is loaded on startup, it should remove all issues reported in #1839. Closes #1716. Closes #1163. Closes #1839.
6 tasks
jniles
added a commit
that referenced
this issue
Sep 20, 2017
This commit completely rewrites the Trail Balance removing the old multi-controller headers and replacing it with a single modal controller and substate controllers for the modal body. It also introduces the Trial Balance Service that interacts with the server to load the Trial Balance. Key Differences/Features: 1. Data is loaded a single time - no additional requests are made for data-by-account. 2. Instantaneously switching between error and overview states. 3. More room on the UI grid display 4. ui-grid complexity reduce by removing grid grouping and features. 5. [IN PROGRESS] Links to filter the journal based on the account and transaction. Since all data is loaded on startup, it should remove all issues reported in #1839. Closes #1716. Closes #1163. Closes #1839.
jniles
added a commit
that referenced
this issue
Sep 21, 2017
This commit completely rewrites the Trail Balance removing the old multi-controller headers and replacing it with a single modal controller and substate controllers for the modal body. It also introduces the Trial Balance Service that interacts with the server to load the Trial Balance. Key Differences/Features: 1. Data is loaded a single time - no additional requests are made for data-by-account. 2. Instantaneously switching between error and overview states. 3. More room on the UI grid display 4. ui-grid complexity reduce by removing grid grouping and features. 5. [IN PROGRESS] Links to filter the journal based on the account and transaction. Since all data is loaded on startup, it should remove all issues reported in #1839. Closes #1716. Closes #1163. Closes #1839.
jniles
added a commit
that referenced
this issue
Sep 22, 2017
This commit completely rewrites the Trail Balance removing the old multi-controller headers and replacing it with a single modal controller and substate controllers for the modal body. It also introduces the Trial Balance Service that interacts with the server to load the Trial Balance. Key Differences/Features: 1. Data is loaded a single time - no additional requests are made for data-by-account. 2. Instantaneously switching between error and overview states. 3. More room on the UI grid display 4. ui-grid complexity reduce by removing grid grouping and features. 5. [IN PROGRESS] Links to filter the journal based on the account and transaction. Since all data is loaded on startup, it should remove all issues reported in #1839. Closes #1716. Closes #1163. Closes #1839.
jniles
added a commit
that referenced
this issue
Sep 22, 2017
This commit completely rewrites the Trail Balance removing the old multi-controller headers and replacing it with a single modal controller and substate controllers for the modal body. It also introduces the Trial Balance Service that interacts with the server to load the Trial Balance. Key Differences/Features: 1. Data is loaded a single time - no additional requests are made for data-by-account. 2. Instantaneously switching between error and overview states. 3. More room on the UI grid display 4. ui-grid complexity reduce by removing grid grouping and features. 5. [IN PROGRESS] Links to filter the journal based on the account and transaction. Since all data is loaded on startup, it should remove all issues reported in #1839. Closes #1716. Closes #1163. Closes #1839.
jniles
added a commit
that referenced
this issue
Sep 25, 2017
This commit completely rewrites the Trail Balance removing the old multi-controller headers and replacing it with a single modal controller and substate controllers for the modal body. It also introduces the Trial Balance Service that interacts with the server to load the Trial Balance. Key Differences/Features: 1. Data is loaded a single time - no additional requests are made for data-by-account. 2. Instantaneously switching between error and overview states. 3. More room on the UI grid display 4. ui-grid complexity reduce by removing grid grouping and features. 5. [IN PROGRESS] Links to filter the journal based on the account and transaction. Since all data is loaded on startup, it should remove all issues reported in #1839. Closes #1716. Closes #1163. Closes #1839.
bors bot
added a commit
that referenced
this issue
Sep 25, 2017
2085: refactor: Posting Journal and Associated Tools r=mbayopanda a=jniles This Pull Request finalizes the refactor of the Posting Journal and associated modules. The commit history contains a full list of changes. In brief: 1. Editing has been moved out into a modal. By breaking out the editing code, the complexity of the Posting Journal is reduced. It also enforces editing a single transaction at a time. 2. The Trial Balance has moved into Stored Procedures. This separates the JS code from the SQL code and speeds up the execution of the Trail Balance slightly. 3. The Trial Balance no longer reloads data between `$state` changes. The modal is much more snappy than previous. 4. Links to the receipts/documents/patients associated with each transaction are embedded in the Posting Journal. This makes it easy to find the details associated with a given transaction. 5. The Posting Journal is able to load "posted" transactions. To accommodate this, the Posting Journal footer has been improved to show the number of unposted or posted transactions. Additionally, the "Posted Journal" module has been removed. There have been a number of miscellaneous bug fixes addressed as well. As with any change, this may introduce new bugs specific to the changes listed above. Partially addresses #1432. Closes #1034. Closes #1163. Closes #1402. Closes #1500. Closes #1640. Closes #1659. Closes #1716. Closes #1717. Closes #1724. Closes #1832. Closes #1839. Closes #1921. Closes #1928. Closes #1934. Closes #1943. Closes #1944. Closes #1948. Closes #1950. Closes #1961. Closes #2031. Closes #2041. --- ### TODO Before Merge - [x] Ensure all keys are translated into both French and English - [x] Ensure tests pass - [x] Make sure all filters/links work on Posting Journal page. - [x] Make sure all filters/links work on the Trial Balance - [x] Ensure all editors work as expected. - [x] Ensure that new code passes lint checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think this bug report may have been made before. Sometimes the trial balance loads with a blank interface displaying no transactions. When this happens it is necessary to close the trail balance and open it again. This is a very bad user experience, especially when the trial balance takes a long time to load.
The text was updated successfully, but these errors were encountered: