Lo L1B - Species Identification and Badtimes Initialization #1615
Merged
sdhoyt merged 2 commits intoIMAP-Science-Operations-Center:devfrom Apr 14, 2025
Merged
Lo L1B - Species Identification and Badtimes Initialization #1615sdhoyt merged 2 commits intoIMAP-Science-Operations-Center:devfrom
sdhoyt merged 2 commits intoIMAP-Science-Operations-Center:devfrom
Conversation
sdhoyt
added
Ins: Lo
sdhoyt
requested review from
KenWFairchild,
frahmanif,
greglucas,
nkerman,
tmplummer and
vmartinez-cu
greglucas
approved these changes
Apr 14, 2025
| l1b_de : xarray.Dataset | ||
| The L1B DE dataset with the bad times added. | ||
| """ | ||
| # Initialize all times as not bad for now |
Collaborator
There was a problem hiding this comment.
Add a note/todo about coming back to this?
Comment on lines
+477
to
+481
| "tof2": ("epoch", [14, 80, 500, fill_val]), | ||
| } | ||
| ) | ||
|
|
||
| expected_species = np.array(["H", "O", "U", "U"]) |
Collaborator
There was a problem hiding this comment.
Add a value under and between too.
Suggested change
| "tof2": ("epoch", [14, 80, 500, fill_val]), | |
| } | |
| ) | |
| expected_species = np.array(["H", "O", "U", "U"]) | |
| "tof2": ("epoch", [1, 14, 50, 80, 500, fill_val]), | |
| } | |
| ) | |
| expected_species = np.array(["U", "H", "U", "O", "U", "U"]) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
This PR adds code to identify the species of each Lo L1B Direct Event as either Hydrogen, Oxygen, or Unknown. The badtimes field is also initialized.
Updated Files
Testing
Added two unit tests and ran CLI
Closes #1517