CoDICE: Initial L1b pipeline#1663
CoDICE: Initial L1b pipeline#1663bourque merged 20 commits intoIMAP-Science-Operations-Center:devfrom
Conversation
bourque
added
Ins: CoDICE
There was a problem hiding this comment.
Pull Request Overview
This PR establishes the initial L1b processing pipeline for CoDICE by updating the framework to convert L1a counts to L1b float rates.
- Updated test files to reflect new CDF file naming conventions and data paths.
- Refactored the L1b processing function to accept file paths and derive logical source attributes.
- Revised global CDF attribute configurations to adopt consistent naming patterns and to add the hi‑priority product.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| imap_processing/tests/codice/test_codice_l1b.py | Renamed variables and test function to reflect logical source names. |
| imap_processing/tests/codice/conftest.py | Updated data path variable names and file references. |
| imap_processing/codice/constants.py | Added a mapping between descriptors and APID constants. |
| imap_processing/codice/codice_l1b.py | Refactored processing logic to load CDF files and derive attributes. |
| imap_processing/cdf/config/imap_codice_global_cdf_attrs.yaml | Modified attribute keys and descriptions to match new naming styles. |
Comments suppressed due to low confidence (2)
imap_processing/codice/codice_l1b.py:9
- Typo in the parameter name 'l1a_filenanme'; it should be corrected to 'l1a_filename' for clarity and consistency.
dataset = process_codice_l1b(l1a_filenanme)
imap_processing/cdf/config/imap_codice_global_cdf_attrs.yaml:158
- The Data_type description for the 'imap_codice_l1b_lo-counters-singles' logical source appears inconsistent; consider updating it to 'L1B_lo-counters-singles' to accurately reflect the data product.
Data_type: L1B_lo-counters-aggregated->Level-1B Lo Single Instrument Rates Data
There was a problem hiding this comment.
A lot of the changes in this file are just straight copy-paste updates that have been made to the L1a attributes file since I initially implemented the L1b file.
tech3371
left a comment
tech3371
left a comment
There was a problem hiding this comment.
The code changes makes sense on high-level. Sorry for being behind on these.
|
|
||
| # Use the logical source as a way to distinguish between data products and | ||
| # set some useful distinguishing variables | ||
| dataset_name = l1a_dataset.attrs["Logical_source"].replace("_l1a_", "_l1b_") |
There was a problem hiding this comment.
should we rename this to be logical_source_name?
There was a problem hiding this comment.
I think I will leave it as dataset_name to be consistent with how I use this in the L1a pipeline
greglucas
left a comment
greglucas
left a comment
There was a problem hiding this comment.
Just some minor nits/suggestions, but looks good otherwise. Not ideal with the /100 so hopefully that can be fixed up soon.
bourque
merged commit 5ac07b3
into
IMAP-Science-Operations-Center:dev
This PR sets up the initial infrastructure/framework for CoDICE L1b processing. Technically I already had an L1b pipeline in place to appease the SIT-3 test, but it didn't really do anything. These modifications get CoDICE in a better place to perform actual L1b processing.
CoDICE L1a -> L1b processing involves converting counts to rates in the various L1a data products. For now, I am simply dividing the counts by an integer to convert the data arrays to float values, but this will be expanded and implemented properly in a future PR.
Pertains to #405