-
Notifications
You must be signed in to change notification settings - Fork 22
Update to latest IMAP frames kernel #2245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest IMAP frames kernel #2245
Conversation
…und calibration report
maxinelasp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I think probably you should wait for a review from @laspsandoval since the main changes are to her code.
| SpiceFrame.IMAP_HI_90: 15 / 360, # (285 + 90) % 360 = 15 | ||
| SpiceFrame.IMAP_ULTRA_45: 123 / 360, # 33 + 90 = 123 | ||
| SpiceFrame.IMAP_ULTRA_90: 300 / 360, # 210 + 90 = 300 | ||
| # Phase offset values based on imap_100.tf frame kernel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a little more detail on how these were generated from the kernel? If I was meant to update these values I would have no clue how to do it.
|
|
||
| # Get static mount matrix | ||
| mount_matrix = spice.pxform(instrument_frame.name, spacecraft_frame.name, 0.0) | ||
| mount_matrix = spice.pxform(instrument_frame.name, spacecraft_frame.name, 0.0).T |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. Looks good to me.
laspsandoval
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good Tim. Thank you.
2669637
into
IMAP-Science-Operations-Center:dev
Change Summary
Overview
Update IMAP frames kernel to version 100 kernel from APL based on gro…und calibration report.
New Files
Updated Files
Closes: #2140