-
Notifications
You must be signed in to change notification settings - Fork 22
ULTRA l2 remove background rate subtraction from corrected counts #2376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ULTRA l2 remove background rate subtraction from corrected counts #2376
Conversation
greglucas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like something that will need to be remembered later to remove and how do we decide when to remove it... We should follow up with Ultra on Wednesday about how to go about this rather than one-off notes to us as this seems like something easy to overlook in future science papers to me.
Yeah that is a good point. I can definitely see this slipping through the cracks. There are actually a lot of things like this that they have asked to be "turned off" for now that we need to add back later. I will bring these up Wednesday
|
I wonder if we can add a global flag somewhere that you can add so we can do something like |
Change Summary
Overview
The ULTRA team would like the background rates to be reported but not subtracted when calculating the corrected counts. Once they get a sense of what the background rates are then they will ask to add it back.
Updated Files
Testing
Fix test. I had to raise the tolerance up for the test that compares the helio intensity to the rectangular intensity.