Skip to content

Conversation

@lacoak21
Copy link
Contributor

@lacoak21 lacoak21 commented Nov 3, 2025

Change Summary

Overview

The ULTRA team would like the background rates to be reported but not subtracted when calculating the corrected counts. Once they get a sense of what the background rates are then they will ask to add it back.

Updated Files

  • imap_processing/ultra/l2/ultra_l2.py
    • Do not subtract bg_rates for now.

Testing

Fix test. I had to raise the tolerance up for the test that compares the helio intensity to the rectangular intensity.

@lacoak21 lacoak21 added this to the November 2025 milestone Nov 3, 2025
@lacoak21 lacoak21 self-assigned this Nov 3, 2025
@lacoak21 lacoak21 added this to IMAP Nov 3, 2025
Copy link
Collaborator

@greglucas greglucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like something that will need to be remembered later to remove and how do we decide when to remove it... We should follow up with Ultra on Wednesday about how to go about this rather than one-off notes to us as this seems like something easy to overlook in future science papers to me.

@lacoak21
Copy link
Contributor Author

lacoak21 commented Nov 3, 2025

This seems like something that will need to be remembered later to remove and how do we decide when to remove it... We should follow up with Ultra on Wednesday about how to go about this rather than one-off notes to us as this seems like something easy to overlook in future science papers to me.

Yeah that is a good point. I can definitely see this slipping through the cracks.

There are actually a lot of things like this that they have asked to be "turned off" for now that we need to add back later. I will bring these up Wednesday

  • energy bins (we are already going to talk about that Wednesday)
  • Boundary scale factors
  • scattering thresholds.
  • background rates.

@lacoak21 lacoak21 merged commit 1a32b5c into IMAP-Science-Operations-Center:dev Nov 3, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this to Done in IMAP Nov 3, 2025
@lacoak21 lacoak21 deleted the ultra_remove_bg_rate_subtraction branch November 3, 2025 22:07
@greglucas
Copy link
Collaborator

There are actually a lot of things like this that they have asked to be "turned off" for now that we need to add back later. I will bring these up Wednesday

I wonder if we can add a global flag somewhere that you can add so we can do something like if ONLY_DURING_COMMISSIONING: so that you can set that flag or something along those lines and it automatically happens the other way after that then. It will be good to bring up with them for discussion 👍

tech3371 pushed a commit to tech3371/imap_processing that referenced this pull request Nov 4, 2025
tech3371 pushed a commit to tech3371/imap_processing that referenced this pull request Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants