FIX: Lo l1b_de needs to expand l1a met to each direct event #2397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greglucas
added
Ins: Lo
Previously, it was only calculating this per ASC, where there are multiple direct events per ASC. We can repeat the individual MET entries by the number of direct events in that ASC.
greglucas
force-pushed
the
lo-l1b-spin-met-shape
branch
from
99b7b9a to
89f5f18
Compare
sdhoyt
approved these changes
Nov 10, 2025
Contributor
sdhoyt
left a comment
sdhoyt
left a comment
There was a problem hiding this comment.
Thanks for figuring this issue out!
greglucas
merged commit d900415
into
IMAP-Science-Operations-Center:dev
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it was only calculating this per ASC, where there are multiple direct events per ASC. We can repeat the individual MET entries by the number of direct events in that ASC.
The test was assuming MET in l1a was the number of direct events, this turns out not to be the case. I think this is right here, but we could also update the l1a dataset to put MET in terms of direct_events as well.