ULTRA l2 fix rectangular map ancillary products

[lacoak21]

Change Summary

closes #3012

Related to IMAP-Science-Operations-Center/imap_L3_processing#82

Overview

Push / pull ancillary variables to a rectangular map directly. Keep ena_instensity calculation the same.

File changes

• imap_processing/ultra/l2/ultra_l2.py
  • Adds direct rectangular projection path for ancillary variables
  • limits recursive conversion to intensity-related variables.
• imap_processing/tests/ultra/unit/test_ultra_l2.py
  • Adds a unit test for rectangular skymap generation
  • updates calls to the renamed skymap generator.

Testing

Update ultra l2 tests

[Copilot]

Pull request overview

This PR updates ULTRA L2 rectangular map generation so that ancillary variables are projected directly into the rectangular grid from L1C pointing sets, while ENA intensity products continue to be derived via HEALPIX-to-rectangular recursive subdivision (per issue #3012).

Changes:

• Renames and generalizes the map builder to generate_ultra_skymap(...) with a build_rectangular_map mode.
• For rectangular outputs, builds a direct rectangular map for ancillary variables and merges in recursively converted intensity variables only.
• Adds a unit test covering direct rectangular map generation and updates existing tests to use the renamed function.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File	Description
imap_processing/ultra/l2/ultra_l2.py	Adds direct rectangular projection path for ancillary variables; limits recursive conversion to intensity-related variables.
imap_processing/tests/ultra/unit/test_ultra_l2.py	Adds a unit test for rectangular skymap generation; updates calls to the renamed skymap generator.

Comments suppressed due to low confidence (2)

imap_processing/ultra/l2/ultra_l2.py:396

• This function mutates the caller-provided output_map_structure in-place (via .extend(...) and later overwriting the lists). This is risky because the module-level DEFAULT_ULTRA_L2_MAP_STRUCTURE can be mutated across calls, and ultra_l2() now calls this function twice for rectangular output. Prefer working on local copies (or a deep-copied map structure) to avoid cross-call side effects.

    # Add additional data variables to the map
    output_map_structure.values_to_push_project.extend(
        [
            "num_pointing_set_pixel_members",
            "obs_date_range",

imap_processing/ultra/l2/ultra_l2.py:723

• Same issue here: assign_coords() is not in-place, so the epoch coordinate update is currently a no-op for the Healpix map as well. Assign the returned Dataset back (or set the coord directly).

    healpix_skymap.data_1d.assign_coords(
        epoch=(
            (CoordNames.TIME.value,),
            [
                pset_epochs.min(),

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[tmplummer]

This all looks good and makes sense to me.