Glows imap start time#3091
Merged
laspsandoval merged 4 commits intoIMAP-Science-Operations-Center:devfrom Apr 30, 2026
Merged
Conversation
maxinelasp
approved these changes
Apr 28, 2026
Contributor
maxinelasp
left a comment
maxinelasp
left a comment
There was a problem hiding this comment.
Awesome! Thanks Laura!
laspsandoval
force-pushed
the
glows_imap_start_time
branch
from
5beeda0 to
1b25dd4
Compare
laspsandoval
merged commit de57e30
into
IMAP-Science-Operations-Center:dev
14 checks passed
maxinelasp
pushed a commit
to maxinelasp/imap_processing
that referenced
this pull request
May 1, 2026
lacoak21
pushed a commit
to lacoak21/imap_processing
that referenced
this pull request
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the robustness of the GLOWS L1A processing pipeline by filtering out histogram data with invalid timing information and enhances test coverage to ensure this behavior. The most important changes are grouped below:
Data Validation Improvements:
generate_histogram_datasetfunction inglows_l1a.pynow filters out histograms whereimap_start_time.seconds == 0, logging a warning when such entries are found. This prevents invalid timing data from being included in downstream processing.Testing Enhancements:
in_flight_packet_path,in_flight_decom_test_data) inconftest.pyto support testing with in-flight packet data containing edge cases. [1] [2]test_generate_histogram_dataset_filters_zero_imap_start_timeto verify that histograms with zeroimap_start_timeare correctly excluded from the dataset.test_glows_l1a_no_zero_imap_start_timeto confirm that the full L1A processing pipeline produces datasets without any zeroimap_start_timevalues, and to check the number of excluded histograms.Test Setup and Imports:
test_glows_l1a_cdf.pyto include necessary modules and classes for the new tests.