Import components when seeding the -edit file.#11
Merged
Conversation
When seeding a new repository, if the ODK is configured to manage import declarations, then we shoud generate import declarations not only for the import modules and the patterns-derived definitions, but also for the components. This is what we do here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When seeding a new repository, if the ODK is configured to manage import declarations, then we should generate import declarations not only for the import modules and the patterns-derived definitions, but also for the components. This is what this PR does.
Without that, the ODK behaves inconsistently in that it will properly inject all the import declarations (for import modules, components, and patterns-derived definitions) when a repository is updated, but will not inject the import declarations for components when the repository is seeded for the first time.
Addresses INCATools/ontology-development-kit#1331 (this comment).