Exclude x86_64 macOS from the seeding tests.#12
Merged
Conversation
Running the seeding tests using the "native" ODK setup takes about: * 18 to 22 minutes on the x86_64 GNU/Linux (Ubuntu) runners; * 15 to 18 minutes on the arm64 macOS runners; * 35 to 40 minutes on the x86_64 macOS runners. So for some reason, it takes twice as much time to run the seeding tests on x86_64 macOS than on arm64 macOS. Given how few people seem to use the ODK on x86_64 macOS machines, systematically testing the native ODK setup for this platform does not seem worth it -- it is expected that very few ODK users will ever use the native setup anyway (Docker remains the primary way of using the ODK, at least for now), so the intersection of "ODK users on x86_64 macOS" and "ODK users willing to use the native setup" might very well be the empty set. The native setup will still be _supported_ (for now?) on x86_64 macOS -- it will just not be _tested_ as much as for the x86_64 GNU/Linux and arm64 macOS platforms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running the seeding tests using the "native" ODK setup takes about:
So for some reason, it takes twice as much time to run the seeding tests on x86_64 macOS than on arm64 macOS.
Given how few people seem to use the ODK on x86_64 macOS machines, systematically testing the native ODK setup for this platform does not seem worth it -- it is expected that very few ODK users will ever use the native setup anyway (Docker remains the primary way of using the ODK, at least for now), so the intersection of "ODK users on x86_64 macOS" and "ODK users willing to use the native setup" might very well be the empty set.
The native setup will still be supported (for now?) on x86_64 macOS -- it will just not be tested as much as for the x86_64 GNU/Linux and arm64 macOS platforms.