Use OFN as the intermediate format more widely.#8
Merged
Conversation
218b2dc to
c9db026
Compare
OFN is already the default intermediate format for import modules and components. This commit makes it the format for more files, including: * the $(EDIT_PREPROCESSED) file; * the $(SRCMERGED) file (strictly speaking this is not necessary: the `$(SRCMERGED)` variable points to a file with a `.ofn` extension, so ROBOT already writes that file in OFN format; * remotely sourced components; * the merged mirror file.
c9db026 to
83b48b0
Compare
matentzn
reviewed
Apr 20, 2026
matentzn
left a comment
There was a problem hiding this comment.
Here is one that makes sense to change:
$(TRANSLATIONSDIR)/%.babelon.owl: $(TRANSLATIONSDIR)/%-preprocessed.babelon.tsv
$(BABELONPY) convert $< --output-format owl -o $@.tmp
$(ROBOT) merge -i $@.tmp \
annotate \
--ontology-iri $(ONTBASE)/translations/$*.babelon.owl \
-V $(ONTBASE)/releases/$(VERSION)/translations/$*.babelon.owl \
--annotation owl:versionInfo $(VERSION) \
convert -f owl --output $@
Silly and not necessary in this PR (only cosmetic if you want to fix and boost performance a bit):
reason_test: $(EDIT_PREPROCESSED)
$(ROBOT) reason --input $< --reasoner $(REASONER) --equivalent-classes-allowed {{ project.allow_equivalents }} \
--exclude-tautologies {{ project.exclude_tautologies }} --output test.owl && rm test.owl
We can drop --output test.owl && rm test.owl to not even generate this file at all.
Collaborator
Author
Along with its siblings
I plan to deal with this type of silliness in a dedicated, “Uberon-Makefile-cleanup-style” PR later. :) |
OWL translation files (`$(TRANSLATIONSDIR)/*.owl`) are intermediate files (they are used to produce the "international" release product), so we switch them to OFN format as the other intermediate files.
matentzn
approved these changes
Apr 20, 2026
|
wonderful PR and much needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OFN is already the default intermediate format for import modules and components. This commit makes it the format for more files, including:
$(SRCMERGED)variable points to a file with a.ofnextension, so ROBOT already writes that file in OFN format;Part of INCATools/ontology-development-kit#1299