Add metadata-based reranking to search results#39
Closed
zohaib-7035 wants to merge 2 commits intoINCF:mainfrom
Closed
Add metadata-based reranking to search results#39zohaib-7035 wants to merge 2 commits intoINCF:mainfrom
zohaib-7035 wants to merge 2 commits intoINCF:mainfrom
Conversation
Collaborator
|
Closing — the reranking score math is incorrect. Adding year/10000 (~0.2) and citations/100 as flat boosts to normalized relevance scores completely distorts the ranking regardless of semantic match quality. A dataset from 2024 with 1000 citations would get +0.2024 + 10.0 boost, drowning out any relevance signal. The feature idea is valid but the scoring needs a proper normalization strategy (e.g. min-max scaling, log normalization). Please rethink the math and reopen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR introduces a metadata-based reranking feature to improve the relevance of search results in the Knowledge Space Agent. Search results are now scored and reordered based on:
Changes:
rerank_results_using_metadata()function inks_search_tool.py.general_searchandsmart_knowledge_search.Testing:
Tested with sample queries like
mouse brain,memory, andhippocampus. Results were correctly reranked according to metadata.Screenshot of test output:
Impact: