fix: derived properties return unmodifiable collections#1923
Merged
surli merged 1 commit intoINRIA:masterfrom Mar 20, 2018
Merged
fix: derived properties return unmodifiable collections#1923surli merged 1 commit intoINRIA:masterfrom
surli merged 1 commit intoINRIA:masterfrom
Conversation
Collaborator
|
I mark this one as breaking as it can be a breaking behaviour in some clients. We'll be able to notice it easily in the changelog then. Thanks @pvojtechovsky ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #1917 and detected by #1922, this PR fixes all main derived properties of Spoon model by way they return unmodifiable collections.
Before they were modifiable, but detached. So the modifications had no influence to the model. Now they are unmodifiable, so client is warn early that modifications makes no sense here.