review: fix class with comments has invalid DeclarationSourcePosition#modifier#1931
Merged
monperrus merged 4 commits intoINRIA:masterfrom Apr 3, 2018
Merged
Conversation
pvojtechovsky
force-pushed
the
positionOnCommentedClass
branch
from
6a70bf1 to
bf647b8
Compare
pvojtechovsky
force-pushed
the
positionOnCommentedClass
branch
from
bf647b8 to
8f22c64
Compare
Collaborator
Author
|
this PR contains another fix related to source position too. The type reference: |
pvojtechovsky
changed the title
Collaborator
|
Thank you for this fix! |
monperrus
reviewed
Apr 2, 2018
|
|
||
| @Test | ||
| public void testPositionClassWithComments() throws Exception { | ||
| final Factory build = build(new File("src/test/java/spoon/test/position/testclasses/")); |
monperrus
reviewed
Apr 2, 2018
|
|
||
| @Test | ||
| public void testPositionParameterTypeReference() throws Exception { | ||
| //contract: the parameterized type refernce has a source position which includes parameter types, etc. |
Collaborator
|
seems like a serious series of changes about positions :-) |
Collaborator
Author
the bugs becomes visible in the light of my experimenting with the sniper mode. This is ready for merge too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am experimenting with another approach to implement Sniper mode and have found a bug:
Class with sources like this
has wrong DeclarationSourcePosition#modifier end.
The problem is in code
/spoon-core/src/main/java/spoon/support/compiler/jdt/PositionBuilder.java (line 137)
because it doesn't count with comments. So we need some comment aware parser/tokenizer here.
I guess, I can fix it. But if anybody else would like to implement that comment parser, I would gladly do something else ;-)