help: fix: always create new type reference for primitive type#1940
Merged
monperrus merged 3 commits intoINRIA:masterfrom Apr 3, 2018
Merged
Conversation
Do not clone them, because it copies source position, etc.
Collaborator
Author
|
This PR actually fails on @surli @monperrus please have a look at it and fix the test or explain me what was the idea, so I can fix it. |
Collaborator
|
it was a fix, see #970. however, like you, when looking at the test and the spooned code, it's unclear. I would suggest to go ahead, change the assertion!(and we'll see if dropwizard fails again, and we'll try to better fix it) |
Collaborator
Author
|
I guess the assertion was intended for the annotated field. So I changed it this way. I am finished here. It is ready for merge from my point of view |
Collaborator
|
Thanks Pavel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type references to primitive types like
voidsometime copied the source position from another type reference. See test for details.