review: feature: SourcePosition checks validity and displays origin source code

[pvojtechovsky]

this new checkArgsAreAscending found many problems in PositionBuilder...

I guess it should be always activated... or do you think it should be possible to switch it off ... temporarily, so clients can use spoon until we fix all the PositionBuilder x JDK compiler problems?

WDYT?

Yes and there are some new helper methods in SourcePositions ... I was lazy to make new PR for them. I hope it is BS enough :-)

[tdurieux]

rebase?

[tdurieux]

with this #1963 this PR should pass.

[pvojtechovsky]

I am finished here

[monperrus]

lots of progress on the position front!

can checkArgsAreAscending throw an exception in pure AST manipulation mode (ie outside JDTTreeBuilder)?

could you add test cases for the new public methods?

[pvojtechovsky]

can checkArgsAreAscending throw an exception in pure AST manipulation mode (ie outside JDTTreeBuilder)?

I am not sure whether I understood the question.
If client just manipulates spoon elements it doesn't creates SourcePositions so checkArgsAreAscending is not called. If client starts to create SourcePositions they must be consistent, otherwise checkArgsAreAscending will report this problem by thrown exception

Tests

ok, I will add some

[pvojtechovsky]

I am finished here

[spoon-bot]

API changes: 1 (Detected by Revapi)

Old API: fr.inria.gforge.spoon:spoon-core:jar:6.3.0-20180405.225214-41 / New API: fr.inria.gforge.spoon:spoon-core:jar:6.3.0-SNAPSHOT

	visibility reduced
Old	method ElementPrinterHelper#createListPrinter(boolean, String, boolean, boolean, String, boolean, boolean, String)
New	method ElementPrinterHelper#createListPrinter(boolean, String, boolean, boolean, String, boolean, boolean, String)
Breaking	binary: breaking