refactor: printing of lists in DefaultJavaPrettyPrinter#1956
Merged
monperrus merged 1 commit intoINRIA:masterfrom Apr 12, 2018
Merged
refactor: printing of lists in DefaultJavaPrettyPrinter#1956monperrus merged 1 commit intoINRIA:masterfrom
monperrus merged 1 commit intoINRIA:masterfrom
Conversation
Collaborator
|
API changes: 1 (Detected by Revapi) Old API: fr.inria.gforge.spoon:spoon-core:jar:6.3.0-20180405.225214-41 / New API: fr.inria.gforge.spoon:spoon-core:jar:6.3.0-SNAPSHOT
|
Collaborator
|
ok for me, refactoring PRs are always welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code is a side effect of my experiments with printing of changes #1927. I though that I will need to know, which list is actually printed by DJPP, so I implemented that
ElementPrinterHelper#printList.Now I see it is not needed, but the code of this PR doesn't look bad from my point of view.
So if you like it, take it. Otherwise close this PR - I do not need that.
This PR also moves printing of method modifier "default" into
ElementPrinterHelper#writeModifiers