review: feat: EqualsVisitor can report which attribute is not equal#1998
Merged
surli merged 2 commits intoINRIA:masterfrom May 22, 2018
Merged
review: feat: EqualsVisitor can report which attribute is not equal#1998surli merged 2 commits intoINRIA:masterfrom
surli merged 2 commits intoINRIA:masterfrom
Conversation
pvojtechovsky
changed the title
Collaborator
|
That is a good feature for debug |
Collaborator
|
We don't have a systematic performance evaluation infrastructure. I propose to merge and see if somebody complains about performance degradation. WDYT? |
Collaborator
Author
|
It is OK for me. |
Collaborator
Actually we might see the difference in the test duration after the merge of the PR here: https://ci.inria.fr/sos/job/Spoon%20Install%20Commit%20Hook/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
please check if performance of Spoon changes with that change. Equals visitor is called very often, so it must be really fast ... and I am not sure about performance impact of this PR