fix(shadow): fix the creation of a partial shadow class

[tdurieux]

It is a little bit dirty, do you have better idea how to do it?

Fix #2038

[pvojtechovsky]

can we catch more exact exception? Such error handling may cause big problems during future debugging.

[tdurieux]

I can do this

[pvojtechovsky]

I suggest to try/catch this line only. So some interfaces are correctly created and some are ignored. Actually it process all interfaces until first which is not on classpath.

Do the same in all cycles of this method, please.

[tdurieux]

I cannot the Error is thrown by clazz.getGenericInterfaces()

[tdurieux]

and I did not succeed to find a way to get a partial list :/

[pvojtechovsky]

So then try/catch only clazz.getGenericSuperclass(). So the exceptions thrown in visitTypeReference are not catched

[tdurieux]

I don't have the motivation to do it, right now.
There is probably 50 invocations to protect in this class.

[pvojtechovsky]

it can be written in nice way using lambda:
for (Type anInterface : ignoreMissingClass(()->clazz.getGenericInterfaces()))
where ignoreMissingClass will return empty collection in case of exception

[tdurieux]

clazz.getGenericInterfaces() returns an array not a collection.
I don't see a way to do it nicely :/

[pvojtechovsky]

<T> T[] ignoreMissingClass(Supplier<T[]> supl) {
  try {
     return supl.get();
   } catch (Throwable e) {
      //TODO check if it is expected problem, else rethrow
      return EMPTY_ARR;
   }
}

[tdurieux]

but the problem is to create EMPTY_ARR, because EMPTY_ARR has to be different for each T

[pvojtechovsky]

This for cycle seems to be copy past here by mistake. It is already above. Please fix it

[tdurieux]

I don't understand it is the only loop on clazz.getDeclaredAnnotations() for visitEnum(Class clazz).
Did I miss something?

[pvojtechovsky]

See line 142-144 in this file

[tdurieux]

It is not the same method

[pvojtechovsky]

I see. First one processes Interface and second one processes Enum. You are right. It is correct. Thanks for explanation.

[monperrus]

LGTM.