review: fix: position of String arg[] and lambda parameter#2149
Merged
tdurieux merged 2 commits intoINRIA:masterfrom Jul 1, 2018
Merged
review: fix: position of String arg[] and lambda parameter#2149tdurieux merged 2 commits intoINRIA:masterfrom
String arg[] and lambda parameter#2149tdurieux merged 2 commits intoINRIA:masterfrom
Conversation
pvojtechovsky
force-pushed
the
fixLambdaPosition
branch
3 times, most recently
from
74832bc to
dec6437
Compare
pvojtechovsky
changed the title
String arg[] and lambda parameterString arg[] and lambda parameter
Collaborator
|
rebase? |
pvojtechovsky
force-pushed
the
fixLambdaPosition
branch
from
dec6437 to
81edc1a
Compare
pvojtechovsky
changed the title
String arg[] and lambda parameterString arg[] and lambda parameter
Collaborator
Author
|
rebase done. note: I have queue of next 4 finished PRs on PositionBuilder. I will make next one after this one is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The computation of position of
String arg[]was not correct for lambda parameters. So fixing of this algorithm fixed position of lambda parameters too.There are also other not-testable fixes which sets correctly maxOffset of findPrevNonWhitespace.