Skip to content

fix(MaintTest): quickfix of ci timeout issues#2667

Merged
monperrus merged 1 commit intoINRIA:masterfrom
nharrand:fix-main-test
Oct 15, 2018
Merged

fix(MaintTest): quickfix of ci timeout issues#2667
monperrus merged 1 commit intoINRIA:masterfrom
nharrand:fix-main-test

Conversation

@nharrand
Copy link
Copy Markdown
Collaborator

@nharrand nharrand commented Oct 15, 2018

This should fix timout issues on travis. It is only a quick fix that print and flush() a message after each package testing for the one test that takes a long time.

The offending test is MainTest#testElementToPathToElementEquivalency() and we might want to rework it. (Keeping in mind that we should not blame whoever wrote it... 😇)

I suggest that we select a meaningful subset of the sources on which it runs. (So far it runs on the complete spoon AST).

@monperrus
Copy link
Copy Markdown
Collaborator

Thanks a lot.

LGTM. Will merge it.

I suggested that we select a meaningful subset of the sources on which it runs. (So far it runs on the complete spoon AST).

Yes! Let's do this in a separate PR. Could you open an issue to keep track of it?

@nharrand
Copy link
Copy Markdown
Collaborator Author

Done!

@monperrus monperrus merged commit e2af5a5 into INRIA:master Oct 15, 2018
@monperrus
Copy link
Copy Markdown
Collaborator

Thanks!

@monperrus
Copy link
Copy Markdown
Collaborator

seems like he quickfix is not enough: https://travis-ci.org/INRIA/spoon/jobs/441787940

@nharrand
Copy link
Copy Markdown
Collaborator Author

That's really weird because the output I just added is indeed printed... Was it the wrong print stream? Well anyway I'll try to reduce the duration of the test overall.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants