fix(MaintTest): quickfix of ci timeout issues#2667
Merged
monperrus merged 1 commit intoINRIA:masterfrom Oct 15, 2018
Merged
Conversation
Collaborator
|
Thanks a lot. LGTM. Will merge it.
Yes! Let's do this in a separate PR. Could you open an issue to keep track of it? |
Collaborator
Author
|
Done! |
Collaborator
|
Thanks! |
Collaborator
|
seems like he quickfix is not enough: https://travis-ci.org/INRIA/spoon/jobs/441787940 |
Collaborator
Author
|
That's really weird because the output I just added is indeed printed... Was it the wrong print stream? Well anyway I'll try to reduce the duration of the test overall. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix timout issues on travis. It is only a quick fix that print and flush() a message after each package testing for the one test that takes a long time.
The offending test is
MainTest#testElementToPathToElementEquivalency()and we might want to rework it. (Keeping in mind that we should not blame whoever wrote it... 😇)I suggest that we select a meaningful subset of the sources on which it runs. (So far it runs on the complete spoon AST).