Skip to content

feat: CtImportVisitor#2730

Merged
monperrus merged 2 commits intoINRIA:masterfrom
pvojtechovsky:feaImportVisitor
Nov 8, 2018
Merged

feat: CtImportVisitor#2730
monperrus merged 2 commits intoINRIA:masterfrom
pvojtechovsky:feaImportVisitor

Conversation

@pvojtechovsky
Copy link
Copy Markdown
Collaborator

@pvojtechovsky pvojtechovsky commented Oct 30, 2018

Simplifies work with different kinds of imports -> CtImportVisitor

@pvojtechovsky pvojtechovsky changed the title feat: CtImportVisitor WIP feat: CtImportVisitor Oct 30, 2018
@pvojtechovsky pvojtechovsky force-pushed the feaImportVisitor branch 2 times, most recently from 126e871 to 4e9c861 Compare November 1, 2018 17:46
@spoon-bot
Copy link
Copy Markdown
Collaborator

API changes: 6 (Detected by Revapi)

Old API: fr.inria.gforge.spoon:spoon-core:jar:7.2.0-20181101.234717-66 / New API: fr.inria.gforge.spoon:spoon-core:jar:7.2.0-SNAPSHOT

Method was added to an interface.
Old none
New method CtImport#accept(CtImportVisitor)
Breaking binary: non_breaking
Method was added to an interface.
Old none
New method CoreFactory#createTypeMemberWildcardImportReference()
Breaking binary: non_breaking
Method was added to an interface.
Old none
New method Factory#createTypeMemberWildcardImportReference(CtTypeReference)
Breaking binary: non_breaking
Method was removed.
Old method CoreFactory#createWildcardStaticTypeMemberReference()
New none
Breaking binary: breaking,
Method was removed.
Old method Factory#createWildcardStaticTypeMemberReference(CtTypeReference)
New none
Breaking binary: breaking,
Method was added to an interface.
Old none
New method CtVisitor#visitCtTypeMemberWildcardImportReference(CtTypeMemberWildcardImportReference)
Breaking binary: non_breaking

@pvojtechovsky pvojtechovsky changed the title WIP feat: CtImportVisitor feat: CtImportVisitor Nov 6, 2018
@pvojtechovsky
Copy link
Copy Markdown
Collaborator Author

It is ready for review.

@monperrus
Copy link
Copy Markdown
Collaborator

LGTM.

@monperrus monperrus merged commit 42caaa7 into INRIA:master Nov 8, 2018
@pvojtechovsky pvojtechovsky deleted the feaImportVisitor branch November 8, 2018 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants