Merged
Conversation
Collaborator
Author
|
I do not understand why it passed before, but as you can see today evening on failing #2683 http://spoon3r.lille.inria.fr/github-webhook//traces/tmp0hpdnorq , the problem is reproducible with code of #2683. This PR is ready for review. Note: after #2820, #2819 and #2813 is merged, I can rebase #2683 and we can start to discuss that PR. I do not see any simple way now, how to make it even smaller. |
Collaborator
|
I love the meta-touch of refactoring of refactoring. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the model is more complicated then the origin code failed, because the checking of the model consistency in the middle of renaming cannot work.
So this PR first changes names and then checks that everything is consistent