-
Notifications
You must be signed in to change notification settings - Fork 1
PR only for Data processing part #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
prasadtalasila
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@8ohamed thanks for the new PR. Please see the comments.
src/config/mqtt.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an advantage of having different cases for configuration in one json file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please apply the suggestions on this file from PR #7
| sorted_keys = sorted(self.data_map.keys()) | ||
|
|
||
| collected_samples = [] | ||
| samples_collected = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be obtained from the size of the previous list?
|
@prasadtalasila |
It is best to have separate config files for that purpose. For example Another suggestion. The files themselves will have credentials. May be it is best to have and add |
|
@8ohamed please let me know when the changes are complete. Thanks. |
|
@prasadtalasila Thanks for the suggestions. I have now pushed the changes. |
|
@prasadtalasila thanks for your help earlier today. |
No description provided.