Fix: Apply low-level compression when no_hatanaka=True#166
Merged
PierreS-alpha merged 1 commit intoIPGP:masterfrom Jan 16, 2026
Merged
Fix: Apply low-level compression when no_hatanaka=True#166PierreS-alpha merged 1 commit intoIPGP:masterfrom
PierreS-alpha merged 1 commit intoIPGP:masterfrom
Conversation
When no_hatanaka=True and compression='Z' or 'gz' is requested, the files were created with compression extensions but the actual compression was not applied, making them unreadable. This commit adds proper low-level compression for non-Hatanaka files: - Use ncompress module for .Z files (LZW compression) - Use gzip module for .gz files The ncompress module is already available as a dependency of hatanaka, and gzip is a Python built-in module, so no new dependencies required. Fixes issue where files like file.rnx.Z were created as plain text instead of being properly compressed with LZW/gzip algorithm.
Member
|
Thanks for spotting the bug! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When no_hatanaka=True and compression='Z' or 'gz' is requested, the files were created with compression extensions but the actual compression was not applied, making them unreadable.
This commit adds proper low-level compression for non-Hatanaka files:
The ncompress module is already available as a dependency of hatanaka, and gzip is a Python built-in module, so no new dependencies required.
Fixes issue where files like file.rnx.Z were created as plain text instead of being properly compressed with LZW/gzip algorithm.