Various fixes to make the examples run as is#13
Merged
MMesch merged 6 commits intoIPGP:masterfrom Jun 12, 2016
Merged
Conversation
…ork after copy paste. Also changing a few things to make the examples work with the given variables.
…g the number of indices in the np.einsum() example as the input arrays are only 2D.
…cated usage of random_integers.
Contributor
Author
|
Btw thanks for creating this, it seems to be very useful as I've run into it on several forums. |
Member
|
Thank you for your contribution(s) :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains various fixes. Only one of the commits is crucial, that fixes the typo in the attribute names in the fft section as well as removes the deprecated usage of numpy's random_integers.
Even though it's a highly unlikely usage, the rest of the changes here was made in the spirit of making the examples copy-pastable after one another.
The changes is quite granular in case you prefer to cherry-pick only a subset.